FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

unified cgroup support by skrzyp1 · Pull Request #5407 · netdata/netdata · GitHub

unified cgroup support - #5407

Merged
vlvkobal merged 9 commits into
netdata:masterfrom
skrzyp1:unified-cgroups-support
Apr 9, 2019
Merged

unified cgroup support#5407
vlvkobal merged 9 commits into
netdata:masterfrom
skrzyp1:unified-cgroups-support

Conversation

skrzyp1 commented Feb 17, 2019
edited by cakrit
Loading

Copy link
Copy Markdown
Contributor
Summary

Fixes #3750

Component Name
Additional Information

CLAassistant commented Feb 17, 2019
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

netdatabot added the area/collectors Everything related to data collection label Feb 18, 2019

cakrit commented Feb 18, 2019

Copy link
Copy Markdown
Contributor

I edited the first comment to add the reference to the issue.

skrzyp1 changed the title WiP unified cgroup support unified cgroup support Mar 29, 2019
netdata deleted a comment from netdatabot Apr 1, 2019
netdata deleted a comment from netdatabot Apr 1, 2019
vlvkobal previously approved these changes Apr 3, 2019

vlvkobal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Tested it and read line by line.
@skrzyp1 don't you want to implement CPU limits? As I see, cgroup v2 provides cpu.max.

skrzyp1 commented Apr 3, 2019

Copy link
Copy Markdown
Contributor Author

@vlvkobal I can implement them too, just wanted to have this part merged so there will be no merge conflicts when other people edit. I can do that as a separate issue is that ok?

vlvkobal commented Apr 4, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

I can do that as a separate issue is that ok?

It is OK. But please update the documentation in this PR.

skrzyp1 commented Apr 8, 2019

Copy link
Copy Markdown
Contributor Author

@cakrit I removed unused variable. @vlvkobal I added info to docs. Is everything ok now?

vlvkobal merged commit 6724b63 into netdata:master Apr 9, 2019
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
* WiP unified cgroup support

* add cpu usage support and disk iops support

* memory limits

* WIP working memory charts

* detailed memory chart

* docs change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/collectors Everything related to data collection

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL