FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added TLS connection support for openldap collector by ekartsonakis · Pull Request #5827 · netdata/netdata · GitHub

/ netdata Public

Added TLS connection support for openldap collector - #5827

Closed
ekartsonakis wants to merge 2 commits into
netdata:masterfrom
ekartsonakis:openldap_tls_support
ConversationCommits (2)ChecksFiles changed
Closed

Added TLS connection support for openldap collector#5827
ekartsonakis wants to merge 2 commits into
netdata:masterfrom
ekartsonakis:openldap_tls_support

Conversation

ekartsonakis commented Apr 9, 2019 •
edited by ilyam8
Loading

Copy link
Copy Markdown
Contributor

openldap collector

Summary

Added support to make secure LDAP TLS connections. User can also choose to skip certificate check in case self signed ones are used.

Fixes: #5783

ekartsonakis requested a review from ilyam8 as a code owner April 9, 2019 21:57

CLAassistant commented Apr 9, 2019 •
edited
Loading

Copy link
Copy Markdown


Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Emmanouil Kartsonakis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

ekartsonakis mentioned this pull request Apr 9, 2019
Closed

ilyam8 commented Apr 10, 2019

Copy link
Copy Markdown
Member

Hey @tctovsli could you please test the PR?

ilyam8 commented Apr 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@ekartsonakis gj 👍 have you tested it?

And please sign the CLA

ekartsonakis commented Apr 10, 2019

Copy link
Copy Markdown
Contributor Author

@ilyam8 yes I tested with all possible options.
OK I just signed.

ilyam8 commented Apr 10, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@ekartsonakis i see the CLA is not signed. The commit is from Emmanouil Kartsonakis, this is the problem.

ilyam8 reviewed Apr 10, 2019
View reviewed changes
Comment thread collectors/python.d.plugin/openldap/openldap.conf Outdated

ilyam8 commented Apr 11, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@ekartsonakis i am not able to merge the PR w/o the CLA being signed

netdatabot added area/collectors Everything related to data collection area/external/python labels Apr 11, 2019

ekartsonakis commented Apr 11, 2019

Copy link
Copy Markdown
Contributor Author

ok signed again.

ilyam8 commented Apr 11, 2019

Copy link
Copy Markdown
Member

@ekartsonakis

check this

your prev PR commits
https://github.com/netdata/netdata/pull/4513/commits

this one
https://github.com/netdata/netdata/pull/5827/commits

different accounts

ilyam8 commented Apr 11, 2019

Copy link
Copy Markdown
Member

Emmanouil Kartsonakis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

ekartsonakis mentioned this pull request Apr 12, 2019
Merged

ilyam8 commented Apr 12, 2019

Copy link
Copy Markdown
Member

closing in favor of #5859

ilyam8 closed this Apr 12, 2019

ekartsonakis commented Apr 12, 2019

Copy link
Copy Markdown
Contributor Author

oohhhh...yes sorry, I used a wrong git config :( sorry. I rebased and created another pull request. So I am closing this one.

ekartsonakis deleted the openldap_tls_support branch April 12, 2019 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ilyam8 ilyam8 approved these changes

Assignees

No one assigned

Labels

area/collectors Everything related to data collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: LDAPS support for openldap-collector

4 participants

Back | FazBrowse Home | New Git URL