This repository was archived by the owner on Jul 17, 2026. It is now read-only.
fix: provide failBuild to getProject calls - #247
Merged
pieh merged 1 commit intoFeb 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
✅ Deploy Preview for plugin-angular-universal-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sorry, something went wrong.
orinokai
approved these changes
Feb 6, 2025
orinokai
left a comment
Copy link
Copy Markdown
There was a problem hiding this comment.
Looks straightforward to me ✅
Sorry, something went wrong.
pieh
deleted the
michalpiechowiak/frb-1619-angular-19-ssr-and-the-angular-runtime
branch
February 6, 2025 09:55
serhalp
pushed a commit
to netlify/framework-adapters
that referenced
this pull request
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've not been passing all the arguments to getProject (
angular-runtime/src/helpers/setUpEdgeFunction.js
Line 25 in 70bbe7f
TypeError: failBuild is not a function at getProject (/opt/build/repo/node_modules/@netlify/angular-runtime/src/helpers/setUpEdgeFunction.js:30:14)kind of errors that hide actual error from the user and making it unnecessarily difficult to see underlying problem
Ideally we also introduce some typechecking to prevent this kind of problems, but this is just quick fix to solve concretely known issue
fixes #246
fixes https://linear.app/netlify/issue/FRB-1619/angular-19-ssr-and-the-angular-runtime