Fix OCSP signature validation when responder is not the issuer - #16079
Merged
normanmaurer merged 4 commits intoJan 9, 2026
Merged
normanmaurer merged 4 commits into
normanmaurer merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@chrisvest @normanmaurer - PTAL :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@hyperxpro Can we use java.security.cert.CertPathBuilder instead of implementing our own DFS path building/verification? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Works, changed :) |
Sorry, something went wrong.
chrisvest
approved these changes
Jan 7, 2026
Copy link
Copy Markdown
Contributor
Author
|
Build PR / linux-x86_64-java11-boringssl-jdk8-tests build (pull_request) 2026-01-07T20:36:02.3491944Z [INFO] 2026-01-07T20:36:02.3493163Z [INFO] Results: 2026-01-07T20:36:02.3493644Z [INFO] 2026-01-07T20:36:02.3494100Z [ERROR] Errors: 2026-01-07T20:36:02.3496352Z [ERROR] DnsNameResolverTest.testTruncatedWithTcpFallback:3300->testTruncated0:3385 ? NullPointer address 2026-01-07T20:36:02.3497992Z [INFO] 2026-01-07T20:36:02.3503200Z [ERROR] Tests run: 297, Failures: 0, Errors: 1, Skipped: 17 2026-01-07T20:36:02.3504160Z [INFO] 2026-01-07T20:36:02.3506111Z [WARNING] Corrupted channel by directly writing to native stream in forked JVM 1. See FAQ web page and the dump file /code/resolver-dns/target/surefire-reports/2026-01-07T19-37-11_697-jvmRun1.dumpstream 2026-01-07T20:36:02.3514025Z [INFO] ------------------------------------------------------------------------ 2026-01-07T20:36:02.3514860Z [INFO] Reactor Summary for Netty 4.2.10.Final-SNAPSHOT: 2026-01-07T20:36:02.3515487Z [INFO] Build PR / linux-x86_64-java11-boringssl build (pull_request) 2026-01-07T20:52:52.7705244Z [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 s -- in io.netty.channel.uring.IoUringSocketRstTest 2026-01-07T20:52:53.3044190Z [INFO] 2026-01-07T20:52:53.3044890Z [INFO] Results: 2026-01-07T20:52:53.3046134Z [INFO] 2026-01-07T20:52:53.3046460Z [ERROR] Errors: 2026-01-07T20:52:53.3049446Z [ERROR] IoUringSocketSslEchoTest.testSslEcho(SslContext, SslContext, Renegotiation, boolean, boolean, boolean, boolean, boolean, TestInfo)[61] ? Timeout testSslEcho(io.netty.handler.ssl.SslContext, io.netty.handler.ssl.SslContext, io.netty.testsuite.transport.socket.SocketSslEchoTest$Renegotiation, boolean, boolean, boolean, boolean, boolean, org.junit.jupiter.api.TestInfo) timed out after 30000 milliseconds 2026-01-07T20:52:53.3052569Z [INFO] 2026-01-07T20:52:53.3053025Z [ERROR] Tests run: 914, Failures: 0, Errors: 1, Skipped: 144 2026-01-07T20:52:53.3053610Z [INFO] Flaky tests, it seems. |
Sorry, something went wrong.
normanmaurer
approved these changes
Jan 9, 2026
normanmaurer
pushed a commit
that referenced
this pull request
Jan 9, 2026
Motivation: OCSP validation currently fails when responses are signed by dedicated OCSP responder certificates. While this is not very common, it is used by apple.com and many other high-traffic websites. Modification: Updated the `validateSignature` method to validate OCSP responses signed by delegated OCSP responders and establish a full chain of trust back to the issuer. Result: Fixes #15829
normanmaurer
pushed a commit
that referenced
this pull request
Jan 9, 2026
Motivation: OCSP validation currently fails when responses are signed by dedicated OCSP responder certificates. While this is not very common, it is used by apple.com and many other high-traffic websites. Modification: Updated the `validateSignature` method to validate OCSP responses signed by delegated OCSP responders and establish a full chain of trust back to the issuer. Result: Fixes #15829
normanmaurer
added a commit
that referenced
this pull request
Jan 9, 2026
… (#16118) Motivation: OCSP validation currently fails when responses are signed by dedicated OCSP responder certificates. While this is not very common, it is used by apple.com and many other high-traffic websites. Modification: Updated the `validateSignature` method to validate OCSP responses signed by delegated OCSP responders and establish a full chain of trust back to the issuer. Result: Fixes #15829 Co-authored-by: Aayush Atharva <24762260+hyperxpro@users.noreply.github.com>
hyperxpro
added a commit
to hyperxpro/netty
that referenced
this pull request
Jul 23, 2026
hyperxpro
added a commit
to hyperxpro/netty
that referenced
this pull request
Jul 23, 2026
hyperxpro
added a commit
to hyperxpro/netty
that referenced
this pull request
Jul 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
OCSP validation currently fails when responses are signed by dedicated OCSP responder certificates.
While this is not very common, it is used by apple.com and many other high-traffic websites.
Modification:
Updated the validateSignature method to validate OCSP responses signed by delegated OCSP responders and establish a full chain of trust back to the issuer.
Result:
Fixes #15829