Auto-port 4.1: Reject negative maxOrder in PooledByteBufAllocator - #17095
Merged
normanmaurer merged 1 commit intoJul 18, 2026
Merged
normanmaurer merged 1 commit into
normanmaurer merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Motivation: The valid range of `maxOrder` is 0 to 14, but negative values were accepted because only the upper bound was validated. When configured through `io.netty.allocator.maxOrder`, a negative value may result in an invalid chunk size during static initialization. Modification: Validate the lower bound of `maxOrder` and add a regression test. Result: Negative `maxOrder` values are rejected with an `IllegalArgumentException`. (cherry picked from commit 010b6e8)
normanmaurer
force-pushed
the
auto-port-pr-17093-to-4.1
branch
from
cd63888 to
101e286
Compare
July 18, 2026 06:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #17093 to 4.1
Cherry-picked commit: 010b6e8
Motivation:
The valid range of maxOrder is 0 to 14, but negative values were accepted because only the upper bound was validated. When configured through io.netty.allocator.maxOrder, a negative value may result in an invalid chunk size during static initialization.
Modification:
Validate the lower bound of maxOrder and add a regression test.
Result:
Negative maxOrder values are rejected with an IllegalArgumentException.