Auto-port 5.0: Fix AdaptiveByteBuf._setLongLE calling checked setLongLE - #17101
Merged
franz1981 merged 1 commit intoJul 15, 2026
Merged
franz1981 merged 1 commit into
franz1981 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Motivation: AdaptiveByteBuf._setLongLE delegates to the checked setLongLE on the root parent, unlike all other _set/_get methods which use the unchecked underscore-prefixed variants. This adds redundant bounds checking and ensureAccessible() on every little-endian long write. Modification: Call rootParent()._setLongLE instead of rootParent().setLongLE. Result: _setLongLE now follows the same unchecked pattern as _setLong, _setInt, _setIntLE, etc. (cherry picked from commit 303d834)
franz1981
approved these changes
Jul 15, 2026
franz1981
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-port of #17098 to 5.0
Cherry-picked commit: 303d834
Motivation:
AdaptiveByteBuf._setLongLE delegates to the checked setLongLE on the root parent, unlike all other _set/_get methods which use the unchecked underscore-prefixed variants. This adds redundant bounds checking and ensureAccessible() on every little-endian long write.
Modification:
Call rootParent()._setLongLE instead of rootParent().setLongLE.
Result:
_setLongLE now follows the same unchecked pattern as _setLong, _setInt, _setIntLE, etc.