Proposal: Rewrite SRA_RUNINFO_TO_FTP as native process - #337
Open
bentsherman wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Copy link
Copy Markdown
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
Sorry, something went wrong.
Copy link
Copy Markdown
nf-core pipelines lint overall result: Passed ✅Posted for pipeline commit 20a3ead +| ✅ 165 tests passed |+
#| ❔ 15 tests were ignored |#❔ Tests ignored:
✅ Tests passed:
Run details
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a POC to demonstrate how to rewrite a simple process as an exec process.
The SRA_RUNINFO_TO_FTP process just transforms a metadata file and doesn't make any network requests, so it can be written purely in Nextflow pretty easily. That way you don't have to spin up a Python job just to do some metadata wrangling.
I think most people don't realize you can do this, due to the (historically) poor developer experience and lack of standard library documentation. Between the new strict syntax and upcoming standard library docs, I'm hoping people might find this approach more appealing.
A further optimization would be to not even write the samplesheet to a TSV file -- just emit the samplesheet as a list of maps.