Dev/add bandit linter support - #204
Draft
mshafer-NI wants to merge 12 commits into
Draft
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thank you for contributing! 👋 |
Sorry, something went wrong.
irwand
approved these changes
Nov 8, 2024
bkeryan
reviewed
Sep 15, 2025
Comment thread
pyproject.toml
| black = ">=23.1" | ||
| bandit = [ | ||
| {version=">=1.5,<1.7", extras=["toml"], python="^3.7,<3.8"}, | ||
| {version=">=1.7.9", extras=["toml"], python="^3.8"}, |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
bandit 1.8.6 requires Python >= 3.9
Sorry, something went wrong.
bkeryan
approved these changes
Sep 15, 2025
Comment thread
ni_python_styleguide/_lint.py
Comment on lines
+73
to
+75
| if key in target and isinstance(value, list): | ||
| _logger.debug("Merging %s: %s", key, value) | ||
| target[key].extend(value) |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Good, this allows projects to extend exclude_dirs.
Sorry, something went wrong.
Comment thread
ni_python_styleguide/_cli.py
| _lint.lint_bandit( | ||
| qs_or_vs=_qs_or_vs(obj["VERBOSITY"]), | ||
| pyproject_config=pyproj_bandit_config, | ||
| file_or_dir=file_or_dir or [pathlib.Path.cwd()], |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
FYI, there is an optional targets key in the config file.
I think defaulting to . and supporting excludes is probably enough for most projects, though.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bandit as a provided tool.
While bandit takes multiple "-c file" parameters, it only uses the latter...
So, to provide a global default (that says it's ok to assert in tests, and to skip a lot of non-python folders), AND support for a using project to provide config in their pyproject.toml, this is setup to load the vendored-config file, and merge in data from pyproject.toml and store the result in a temp file.