docs: add disclaimer about Node.js 18+ native fetch - #1864
Conversation
Sorry, something went wrong.
Add a documentation note informing users that Node.js 18+ already has native fetch built-in, making node-fetch unnecessary for those versions. This helps users avoid unnecessary bundle size increases.
|
Should probably mention that Node's native fetch doesn't support SSRF filtering, and if the user needs that then node-fetch is a reasonable solution when used with https://www.npmjs.com/package/request-filtering-agent |
Sorry, something went wrong.
rsbasic
left a comment
There was a problem hiding this comment.
Review: APPROVE (docs only, LOW risk)
This adds a clear, well-structured disclaimer that Node.js 18+ has built-in fetch. The content is accurate:
- Correctly notes that native fetch eliminates the dependency
- Lists practical benefits (smaller bundles, no maintenance burden)
- Includes a working code example
- Preserves node-fetch as a valid choice for older Node versions (12, 14, 16)
- Links to the official Node.js fetch documentation
The only minor note: the link points to the v18 docs specifically (latest-v18.x). Since this is about 18+ generally, a link to the current LTS docs might age better. But this is cosmetic — the content is correct and helpful.
Verdict: Safe to merge. This is the kind of information users need right now given the maintenance gap.
Sorry, something went wrong.
|
Stale PR (no activity for 4+ weeks). Feel free to reopen if still relevant. |
Sorry, something went wrong.
Description
Adds a documentation disclaimer informing users that Node.js 18+ already has native fetch built-in, making node-fetch unnecessary for those versions.
Motivation
Many users are not aware that Node.js 18+ includes native fetch. This leads to unnecessary installation of node-fetch, increasing bundle size (especially important for serverless deployments).
Changes
This addresses issue #1857.