FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: enhance require profermance by gxcsoccer · Pull Request #36 · node-modules/byte · GitHub

/ byte Public

refactor: enhance require profermance - #36

Open
gxcsoccer wants to merge 1 commit into
masterfrom
enhance-load-prof
ConversationCommits (1)ChecksFiles changed
Open

refactor: enhance require profermance#36
gxcsoccer wants to merge 1 commit into
masterfrom
enhance-load-prof

Conversation

gxcsoccer commented Apr 8, 2019 •
edited
Loading

Copy link
Copy Markdown
Member 
console.time('byte');
require('byte');
console.timeEnd('byte');

优化前

byte: 55.795ms

优化后

byte: 3.092ms

gxcsoccer commented Apr 8, 2019
View reviewed changes
Comment thread lib/byte.js
const importLazy = require('import-lazy')(require);
const Long = importLazy('long');
const numbers = require('./number');
const utility = require('utility');

gxcsoccer Apr 8, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

utility 加载要几十毫秒

codecov Bot commented Apr 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #36 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   94.26%   94.32%   +0.06%     
==========================================
  Files           2        2              
  Lines         366      370       +4     
==========================================
+ Hits          345      349       +4     
  Misses         21       21
Impacted Files Coverage Δ
lib/byte.js 94.3% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c73cb0...23ab4d0. Read the comment docs.

1 similar comment

codecov Bot commented Apr 8, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #36 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage   94.26%   94.32%   +0.06%     
==========================================
  Files           2        2              
  Lines         366      370       +4     
==========================================
+ Hits          345      349       +4     
  Misses         21       21
Impacted Files Coverage Δ
lib/byte.js 94.3% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c73cb0...23ab4d0. Read the comment docs.

gxcsoccer mentioned this pull request Apr 8, 2019
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fengmk2 Awaiting requested review from fengmk2
killagu Awaiting requested review from killagu
popomore Awaiting requested review from popomore

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL