feat: support xz - #112
feat: support xz#112fengmk2 wants to merge 11 commits into
Conversation
Sorry, something went wrong.
closes #96 All codes gen by cursor
|
Warning Rate limit exceeded@fengmk2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 5 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📥 CommitsReviewing files that changed from the base of the PR and between b167355 and d6a07f0. 📒 Files selected for processing (2)
WalkthroughSupport for the XZ compression format has been added. This includes new APIs, streaming classes, and documentation for compressing and decompressing files and streams using XZ/LZMA. The package now depends on lzma-native, and comprehensive tests for XZ functionality are included. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant XzAPI as xz.compressFile / xz.uncompress
participant FileStream as XzFileStream / XzUncompressStream
participant lzma as lzma-native
participant FS as File System
User->>XzAPI: Call compressFile(source, dest, opts)
XzAPI->>FileStream: Instantiate with source, opts
FileStream->>lzma: Create compressor/decompressor stream
FileStream->>FS: Read from source (file/buffer/stream)
FS-->>FileStream: Source data
FileStream->>lzma: Pipe data through compressor/decompressor
lzma-->>FileStream: Compressed/decompressed data
FileStream->>FS: Write to destination
FS-->>User: Result (Promise resolved)
Assessment against linked issues
Poem✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ Share 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (.coderabbit.yaml)
Documentation and Community
|
Sorry, something went wrong.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for xz compression and decompression, including corresponding tests, documentation updates, and library implementations.
- Added xz-related stream implementations for compression and decompression
- Updated tests and README to include xz usage
- Added dependency on lzma-native in package.json
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| test/xz/file_stream.test.js | New tests for xz compression/decompression covering file, buffer, and stream inputs |
| package.json | Added lzma-native dependency |
| lib/xz/uncompress_stream.js | Implementation of an uncompress stream for xz with potential pipe logic issue |
| lib/xz/index.js | Exports for xz functionality |
| lib/xz/file_stream.js | Xz file stream implementation for compression |
| index.js | Updated to export new xz module |
| README.md | Documentation updated to include xz usage |
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (8)test/xz/file_stream.test.js (1)📜 Review detailslib/xz/index.js (2)91-91: Fix trailing spaces.
Remove the trailing spaces at the end of line 91 to resolve the linting failures.
🧰 Tools 🪛 GitHub Check: Node.js / Test (macos-latest, 20)-}); +});[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 18)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 20)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 14)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 24)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 16)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 22)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 16)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 24)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 24)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 14)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 22)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 14)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 16)
Trailing spaces not allowed[failure] 91-91:
Trailing spaces not allowedlib/xz/file_stream.js (2)1-1: Remove redundant 'use strict' directive.
In modern Node.js modules, the 'use strict' directive is automatically applied and is redundant.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
11-11: Fix trailing spaces.
Remove the trailing spaces at the end of line 11 to resolve the linting failures.
🧰 Tools 🪛 GitHub Check: Node.js / Test (macos-latest, 20)-exports.decompress = utils.makeFileProcessFn(XzUncompressStream); +exports.decompress = utils.makeFileProcessFn(XzUncompressStream);[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 18)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 20)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 14)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 24)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 16)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 22)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 16)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 24)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 24)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 14)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 22)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 14)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 16)
Trailing spaces not allowed[failure] 11-11:
Trailing spaces not allowedlib/xz/uncompress_stream.js (2)1-1: Remove redundant strict mode directive.
The 'use strict'; directive is redundant in ES modules as they are automatically in strict mode.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
54-54: Remove trailing spaces.
Multiple CI checks are failing due to trailing spaces at the end of line 54.
🧰 Tools 🪛 GitHub Check: Node.js / Test (macos-latest, 20)-module.exports = XzFileStream; +module.exports = XzFileStream;[failure] 54-54:
🪛 GitHub Check: Node.js / Test (windows-latest, 18)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (windows-latest, 20)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 14)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 24)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (macos-latest, 16)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (windows-latest, 22)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 16)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (windows-latest, 24)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (macos-latest, 24)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (windows-latest, 14)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (macos-latest, 22)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (macos-latest, 14)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
Trailing spaces not allowed[failure] 54-54:
🪛 GitHub Check: Node.js / Test (windows-latest, 16)
Trailing spaces not allowed[failure] 54-54:
Trailing spaces not allowedREADME.md (1)1-1: Remove redundant strict mode directive.
The 'use strict'; directive is redundant in ES modules as they are automatically in strict mode.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
49-49: Remove trailing spaces.
Multiple CI checks are failing due to trailing spaces at the end of line 49.
🧰 Tools 🪛 GitHub Check: Node.js / Test (macos-latest, 20)-module.exports = XzUncompressStream; +module.exports = XzUncompressStream;[failure] 49-49:
🪛 GitHub Check: Node.js / Test (windows-latest, 18)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (windows-latest, 20)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 14)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 24)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (macos-latest, 16)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (windows-latest, 22)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 16)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (windows-latest, 24)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (macos-latest, 24)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (windows-latest, 14)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (macos-latest, 22)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (macos-latest, 14)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
Trailing spaces not allowed[failure] 49-49:
🪛 GitHub Check: Node.js / Test (windows-latest, 16)
Trailing spaces not allowed[failure] 49-49:
Trailing spaces not allowed37-37: Fix grammar issue.
The verb agreement is incorrect in this sentence.
🧰 Tools 🪛 LanguageTool-Use gzip as an example, tar, tgz, zip and xz is same as gzip. +Use gzip as an example, tar, tgz, zip and xz are the same as gzip.[uncategorized] ~37-~37: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...zip as an example, tar, tgz, zip and xz is same as gzip. promise style ```js...(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Reviewing files that changed from the base of the PR and between 9478897 and b104f8f.
⛔ Files ignored due to path filters (1)- test/fixtures/xx.log.xz is excluded by !**/*.xz
- README.md (7 hunks)
- index.d.ts (1 hunks)
- index.js (1 hunks)
- lib/xz/file_stream.js (1 hunks)
- lib/xz/index.js (1 hunks)
- lib/xz/uncompress_stream.js (1 hunks)
- package.json (1 hunks)
- test/xz/file_stream.test.js (1 hunks)
lib/xz/file_stream.js (5)🪛 Biome (1.9.4) lib/xz/index.jstest/xz/file_stream.test.js (1)
- fs (3-3)
- lzma (4-4)
- utils (5-5)
- streamifier (6-6)
- stream (7-7)
lib/xz/index.js (2)
- fs (1-1)
- utils (3-3)
- XzUncompressStream (5-5)
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
lib/xz/uncompress_stream.js[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
lib/xz/file_stream.js[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
🪛 GitHub Check: Node.js / Test (macos-latest, 20) lib/xz/index.js[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[failure] 11-11:
Trailing spaces not allowed
[failure] 91-91:
Trailing spaces not allowed
[failure] 49-49:
Trailing spaces not allowed
[failure] 54-54:
Trailing spaces not allowed
[uncategorized] ~37-~37: This verb does not appear to agree with the subject. Consider using a different form.
Context: ...zip as an example, tar, tgz, zip and xz is same as gzip. promise style ```js...
(AI_EN_LECTOR_REPLACEMENT_VERB_AGREEMENT)
🔇 Additional comments (7)index.js (1)7-7: LGTM! Clean and consistent API integration.
The XZ export follows the same pattern as other compression formats and integrates cleanly with the existing API structure.
test/xz/file_stream.test.js (1)6-91: Excellent test coverage and structure.
The test suite provides comprehensive coverage for XZ compression/decompression functionality:
🧰 Tools 🪛 GitHub Check: Node.js / Test (macos-latest, 20)
- Tests different input types (file paths, buffers, streams)
- Validates both compression and decompression operations
- Includes proper assertions for file existence and content verification
- Implements good cleanup practices for temporary files
- Uses appropriate async/await patterns with error handling
[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 18)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 20)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 14)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 24)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 16)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 22)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 16)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 24)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 24)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 14)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 22)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (macos-latest, 14)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
Trailing spaces not allowed[failure] 91-91:
🪛 GitHub Check: Node.js / Test (windows-latest, 16)
Trailing spaces not allowed[failure] 91-91:
lib/xz/index.js (1)
Trailing spaces not allowed3-11: Well-structured XZ module implementation.
The module follows the established patterns in the library:
🧰 Tools 🪛 GitHub Check: Node.js / Test (macos-latest, 20)
- Clean imports and exports structure
- Consistent use of utils.makeFileProcessFn for file operations
- Provides both class exports and convenience functions
- The decompress alias alongside uncompress provides good API flexibility
[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 18)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 20)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 14)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 24)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 16)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 18)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 20)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 22)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 16)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 24)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 24)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 14)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 22)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 18)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (macos-latest, 14)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (ubuntu-latest, 22)
Trailing spaces not allowed[failure] 11-11:
🪛 GitHub Check: Node.js / Test (windows-latest, 16)
Trailing spaces not allowed[failure] 11-11:
README.md (3)
Trailing spaces not allowed25-25: LGTM! XZ format added to supported formats.
The addition of XZ to the supported formats list is correctly placed and maintains consistency with the existing documentation structure.
239-239: Excellent API documentation coverage.
The XZ API documentation is comprehensive and follows the established pattern for other compression formats. All key methods and classes are properly documented.
Also applies to: 273-273, 297-297, 366-366
322-325: Well-documented XZ-specific parameters.
The documentation for XZ-specific parameters (opts.lzma) is clear and follows the same structure as other format-specific options. This will help users understand how to configure the underlying lzma-native library.
Also applies to: 372-379
index.d.ts (1)203-223: Excellent TypeScript definitions for XZ namespace.
The XZ namespace definitions are comprehensive and follow the exact same pattern as existing compression formats. The type definitions properly cover:
- All async functions with correct Promise return types
- Both FileStream and UncompressStream classes with proper inheritance
- Correct constructor options including the lzma configuration parameter
- Proper event listener overloads for error handling
This maintains excellent type safety and API consistency across all compression formats.
Sorry, something went wrong.
| "flushwritable": "^1.0.0", | ||
| "get-ready": "^1.0.0", | ||
| "iconv-lite": "^0.5.0", | ||
| "lzma-native": "^8.0.5", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chainVerify the lzma-native dependency version for security and compatibility.
The addition of lzma-native dependency looks correct for XZ compression support. However, please verify this version is secure and compatible with the target Node.js versions.
🌐 Web query:
What is the latest version of lzma-native npm package and are there any known security vulnerabilities in version 8.0.5?
💡 Result:
The latest version of lzma-native npm package is 8.0.6, which was published approximately 3 years ago (as of January 2022)[1].
As for lzma-native version 8.0.5, there is some security information available. According to ReversingLabs Spectra Assure Community, the package is not widely used, having about 20 million recorded downloads. However, they caution that a package's popularity is not necessarily an indicator of its safety[4].
While there are no direct vulnerabilities explicitly mentioned for lzma-native version 8.0.5 specifically, it's important to note that the underlying liblzma library (which lzma-native provides bindings to) has had a significant security issue. In early 2024, a critical vulnerability known as CVE-2024-3094 was discovered in the xz/liblzma library[6][7]. This vulnerability resulted from a supply chain attack where malicious code was embedded in the form of .m4 files in tarball distributions.
The vulnerability affected primarily versions 5.6.0 and 5.6.1 of the xz/liblzma library, with the backdoor specifically targeting systems running SSH servers and using liblzma[7]. However, according to available information, lzma-native appears to come with binary version 5.2.3, which is considered safe from this particular vulnerability[8].
For any npm package, it's generally recommended to run security audits using tools like npm audit to check for vulnerabilities in your dependencies[9]. This can help identify known security issues and provide remediation steps.
Citations:
- 1: https://www.npmjs.com/package/lzma-native
- 2: https://github.com/addaleax/lzma-native/blob/main/CHANGELOG.md
- 3: Error building lzma-native on linux with npm=7.6.3 and node=14.16.0 addaleax/lzma-native#112
- 4: https://secure.software/npm/packages/lzma-native/8.0.5
- 5: https://www.npmjs.com/package/@types/lzma-native
- 6: https://security.snyk.io/vuln/SNYK-RUST-LIBLZMA-6515732
- 7: https://www.cynet.com/blog/cve-2024-3094-xz-lzma-vulnerability/
- 8: https://socket.dev/blog/how-to-use-socket-to-find-out-if-you-were-affected-by-the-backdoored-xz-package
- 9: https://docs.npmjs.com/auditing-package-dependencies-for-security-vulnerabilities/
- 10: https://security.snyk.io/package/npm/npm
Upgrade lzma-native to 8.0.6 and audit for security
The current dependency (8.0.5) bundles liblzma 5.2.3, which isn’t affected by CVE-2024-3094, and there are no known vulnerabilities in 8.0.5. However, the latest published version is 8.0.6, which may contain important fixes or improvements.
• In package.json (line 45), change
"lzma-native": "^8.0.5",
to
"lzma-native": "^8.0.6",
• After updating, run npm audit to catch any transitive issues.
• Verify compatibility with your supported Node.js versions.
In package.json at line 45, update the lzma-native dependency version from "^8.0.5" to "^8.0.6" to use the latest published version. After this change, run `npm audit` to check for any security vulnerabilities in this or transitive dependencies. Finally, verify that the updated version remains compatible with the Node.js versions your project supports.
Sorry, something went wrong.
There was a problem hiding this comment.
yes, please change it
Sorry, something went wrong.
There was a problem hiding this comment.
@fengmk2 I'll plan the code change to update the lzma-native dependency version. Another agent will come along and actually execute the changes.
flowchart TB
A["Update lzma-native dependency"]
A --> B["Modify package.json"]
B --> C["Change version from ^8.0.5 to ^8.0.6"]
⏳ Preparing changes...
Sorry, something went wrong.
There was a problem hiding this comment.
A summary of the edits CodeRabbit can apply:
The lzma-native dependency version in package.json will be updated from "^8.0.5" to "^8.0.6".
A plan of each step that CodeRabbit will take in order to execute the edits for each file (with inline rough draft snippets):
✏️ package.jsonOpen package.json and navigate to line 45, which currently reads:
"lzma-native": "^8.0.5",Replace the version string on line 45 with the updated version:
-"lzma-native": "^8.0.5",
+"lzma-native": "^8.0.6",Save your changes to package.json.
Run npm install to update package-lock.json and install lzma-native@^8.0.6.
Execute npm audit to identify any security vulnerabilities in the updated dependency tree.
Run the full test suite, including any compression/uncompression integration tests, to verify compatibility with the supported Node.js versions.
A summary of the context that CodeRabbit is considering across the codebase:
We need to pinpoint the exact location of the lzma-native dependency in package.json so we can update it precisely.
- ✅ Create PR with these edits
- 📌 Create commit in current branch
- 📋 Get copyable edits
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (2)lib/xz/file_stream.js (1)🧹 Nitpick comments (3)lib/xz/uncompress_stream.js (1)43-43: ⚠️ Potential issue
Fix critical bug in pipe event handler.
The pipe event handler incorrectly calls srcStream.unpipe(srcStream) which tries to unpipe the stream from itself. This should be srcStream.unpipe(this) to properly unpipe the source from the current stream.
- srcStream.unpipe(srcStream); + srcStream.unpipe(this);43-43: ⚠️ Potential issue
Fix critical bug in pipe event handler.
The pipe event handler incorrectly calls srcStream.unpipe(srcStream) which tries to unpipe the stream from itself. This should be srcStream.unpipe(this) to properly unpipe the source from the current stream.
- srcStream.unpipe(srcStream); + srcStream.unpipe(this);
lib/xz/index.js (1)📜 Review detailslib/xz/file_stream.js (1)1-1: Remove redundant 'use strict' directive.
In ES modules (which Node.js treats all .js files as by default in modern versions), strict mode is automatically enabled. The 'use strict' directive is redundant and can be removed.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
lib/xz/uncompress_stream.js (1)1-1: Remove redundant 'use strict' directive.
In ES modules, strict mode is automatically enabled. The 'use strict' directive is redundant and can be removed.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
1-1: Remove redundant 'use strict' directive.
In ES modules, strict mode is automatically enabled. The 'use strict' directive is redundant and can be removed.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Reviewing files that changed from the base of the PR and between b104f8f and 58055ea.
📒 Files selected for processing (4)- lib/xz/file_stream.js (1 hunks)
- lib/xz/index.js (1 hunks)
- lib/xz/uncompress_stream.js (1 hunks)
- test/xz/file_stream.test.js (1 hunks)
- test/xz/file_stream.test.js
lib/xz/uncompress_stream.js (5)lib/xz/uncompress_stream.js (3)test/xz/file_stream.test.js (1)
- fs (3-3)
- require (7-7)
- lzma (4-4)
- utils (5-5)
- streamifier (6-6)
lib/xz/index.js (2)
- fs (1-1)
- utils (3-3)
- XzFileStream (4-4)
lib/xz/file_stream.js (5)🪛 Biome (1.9.4) lib/xz/file_stream.jstest/xz/file_stream.test.js (1)
- fs (3-3)
- lzma (4-4)
- utils (5-5)
- streamifier (6-6)
- stream (7-7)
lib/xz/index.js (2)
- fs (1-1)
- utils (3-3)
- XzUncompressStream (5-5)
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
lib/xz/index.js[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
lib/xz/uncompress_stream.js[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
🔇 Additional comments (4)lib/xz/index.js (1)3-11: LGTM! Clean module structure.
The module structure is well-organized with clear imports and exports. The use of utils.makeFileProcessFn to create file processing functions maintains consistency with the existing codebase architecture.
lib/xz/file_stream.js (2)9-46: Well-structured compression stream with proper error handling.
The implementation correctly handles different input types and delegates compression to the lzma compressor stream. Error propagation is properly set up for all stream sources.
48-51: Appropriate _transform implementation.
The empty _transform method is correct here since the actual compression work is delegated to the compressor stream. This follows the intended design pattern.
lib/xz/uncompress_stream.js (1)9-46: Well-implemented decompression stream.
The decompression implementation correctly uses PassThrough stream and handles different input types appropriately. Error handling is properly implemented across all stream sources.
Sorry, something went wrong.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the XZ (LZMA) compression format throughout the library.
- Introduces lib/xz module with file- and stream-based compression/decompression using lzma-native
- Registers xz in package.json, index.js, and updates README.md with usage and API docs
- Adds end-to-end tests under test/xz covering files, buffers, and streams
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file| File | Description |
|---|---|
| test/xz/file_stream.test.js | Tests for compressing/decompressing files, buffers, and streams using compressing.xz |
| package.json | Added lzma-native dependency |
| lib/xz/uncompress_stream.js | New XzUncompressStream implementation |
| lib/xz/file_stream.js | New XzFileStream implementation |
| lib/xz/index.js | Exports for XZ API surface (compressFile, uncompress, decompress, etc.) |
| index.js | Registers exports.xz |
| README.md | Documentation and examples updated to include XZ support |
lib/xz/uncompress_stream.js:48
- There's an extra closing brace at the end of this file, which causes a syntax error. Remove the redundant '}' on line 48.
}
Sorry, something went wrong.
| exports.compressFile = utils.makeFileProcessFn(XzFileStream); | ||
| exports.uncompress = utils.makeFileProcessFn(XzUncompressStream); |
Copilot
AI
May 25, 2025
There was a problem hiding this comment.
[nitpick] The decompress alias duplicates uncompress without a documented difference. Consider removing it or adding documentation for why both names exist.
| exports.compressFile = utils.makeFileProcessFn(XzFileStream); | |
| exports.uncompress = utils.makeFileProcessFn(XzUncompressStream); | |
| exports.compressFile = utils.makeFileProcessFn(XzFileStream); | |
| // Alias for decompressing files. Provided for consistency with other APIs that use "uncompress". | |
| exports.uncompress = utils.makeFileProcessFn(XzUncompressStream); | |
| // Alias for decompressing files. Provided for developer preference and readability. |
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)lib/xz/uncompress_stream.js (1)🧹 Nitpick comments (1)42-45: ⚠️ Potential issue
Fix critical bug in pipe event handler.
The pipe event handler contains the same critical issue previously identified by other reviewers.
Apply this fix:
- srcStream.unpipe(srcStream); + srcStream.unpipe(this);
lib/xz/uncompress_stream.js (1)📜 Review details1-1: Remove redundant 'use strict' directive.
JavaScript modules automatically operate in strict mode, making this directive unnecessary.
🧰 Tools 🪛 Biome (1.9.4)-'use strict';[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Reviewing files that changed from the base of the PR and between 58055ea and 9b17e98.
📒 Files selected for processing (1)- lib/xz/uncompress_stream.js (1 hunks)
[error] 47-48: Expected a statement but instead found '}'.
Expected a statement here.
(parse)
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
⏰ Context from checks skipped due to timeout of 90000ms (1)- GitHub Check: Node.js / Test (windows-latest, 18)
lib/xz/uncompress_stream.js (2)9-41: Well-structured decompression implementation.
The class properly handles different source types with appropriate error propagation and follows good streaming patterns. The separation of logic for file, buffer, and stream sources is clean and maintainable.
17-18: Excellent error handling and stream lifecycle management.
The implementation correctly re-emits errors from the decompressor and properly handles the end event to close the output stream. This follows Node.js streaming best practices.
Sorry, something went wrong.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)lib/xz/index.js (1)🧹 Nitpick comments (2)55-55: Duplicate alias without clear differentiation.
This duplicates the existing concern about the decompress alias. As noted in previous reviews, consider removing this alias or adding documentation to explain why both uncompress and decompress names exist.
lib/xz/index.js (1)📜 Review detailslib/xz/uncompress_stream.js (1)1-1: Remove redundant 'use strict' directive.
Modern JavaScript modules are automatically in strict mode, making this directive unnecessary.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
1-1: Remove redundant 'use strict' directive.
Modern JavaScript modules are automatically in strict mode, making this directive unnecessary.
🧰 Tools 🪛 Biome (1.9.4)-'use strict'; -[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Reviewing files that changed from the base of the PR and between 9b17e98 and ee421a6.
📒 Files selected for processing (4)- README.md (6 hunks)
- lib/xz/index.js (1 hunks)
- lib/xz/uncompress_stream.js (1 hunks)
- package.json (1 hunks)
- package.json
- README.md
lib/xz/file_stream.js (1)lib/xz/uncompress_stream.js (2)lib/xz/uncompress_stream.js (2)
- utils (5-5)
- utils (5-5)
- require (7-7)
lib/xz/file_stream.js (5)🪛 Biome (1.9.4) lib/xz/index.jslib/xz/index.js (2)
- fs (3-3)
- lzma (4-4)
- utils (5-5)
- streamifier (6-6)
- stream (7-7)
- utils (3-3)
- XzUncompressStream (6-6)
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
lib/xz/uncompress_stream.js[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
🔇 Additional comments (5)lib/xz/index.js (2)8-21: Well-designed dependency checking pattern.
The implementation correctly handles the optional lzma-native dependency with proper error checking and informative error messages. The separation between checking and throwing allows for flexible usage patterns.
24-31: Effective lazy loading implementation.
The lazy loading pattern ensures that the optional dependency is only required when actually used, which is essential for optional dependencies. The caching prevents repeated require calls.
lib/xz/uncompress_stream.js (3)9-18: Solid constructor implementation with proper error handling.
The constructor correctly sets up the decompressor and establishes error propagation. The error handling ensures that any issues in the decompression process are properly bubbled up to the consuming code.
21-39: Well-structured source type handling.
The implementation correctly handles different input types (file, buffer, stream) with consistent error propagation patterns. Each source type is properly handled with appropriate stream creation and piping.
42-45: Previous pipe event handler issues have been resolved.
The pipe event handler now correctly calls srcStream.unpipe(this) instead of the previously problematic srcStream.unpipe(srcStream). The implementation properly reroutes the source stream through the decompressor.
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)lib/xz/file_stream.js (1)🧹 Nitpick comments (1)42-45: Pipe event handler is correctly implemented.
Good to see the previous critical bug has been addressed. The srcStream.unpipe(this) correctly unpipes the source from the current transform stream before piping to the compressor.
lib/xz/file_stream.js (1)📜 Review details1-1: Remove redundant 'use strict' directive.
Modern JavaScript modules are automatically in strict mode, making this directive unnecessary.
🧰 Tools 🪛 Biome (1.9.4)-'use strict';[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.(lint/suspicious/noRedundantUseStrict)
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Reviewing files that changed from the base of the PR and between ee421a6 and b167355.
📒 Files selected for processing (3)- README.md (7 hunks)
- lib/xz/file_stream.js (1 hunks)
- test/xz/file_stream.test.js (1 hunks)
- test/xz/file_stream.test.js
- README.md
lib/xz/uncompress_stream.js (5)🪛 Biome (1.9.4) lib/xz/file_stream.jstest/xz/file_stream.test.js (1)
- fs (3-3)
- require (7-7)
- lzma (4-4)
- utils (5-5)
- streamifier (6-6)
lib/xz/index.js (2)
- fs (1-1)
- utils (3-3)
- XzFileStream (5-5)
[error] 1-1: Redundant use strict directive.
The entire contents of JavaScript modules are automatically in strict mode, with no statement needed to initiate it.
Safe fix: Remove the redundant use strict directive.
(lint/suspicious/noRedundantUseStrict)
⏰ Context from checks skipped due to timeout of 90000ms (2)- GitHub Check: Node.js / Test (macos-latest, 20)
- GitHub Check: Node.js / Test (windows-latest, 18)
lib/xz/file_stream.js (2)9-46: Excellent implementation with comprehensive source type handling.
The constructor properly handles different input source types (file, buffer, stream, and pipe) with appropriate error propagation. The pipe event handler has been correctly implemented to unpipe from this stream before redirecting to the compressor.
48-51: Proper Transform stream implementation.
The _transform method correctly delegates processing to the compressor stream by calling the callback immediately without processing chunks directly. This is the appropriate pattern when using an internal stream for actual data transformation.
Sorry, something went wrong.
There was a problem hiding this comment.
Code Review
The pull request introduces support for the xz compression format, which is a valuable addition. The documentation and test coverage appear comprehensive for the new feature. However, there are significant inconsistencies in the TypeScript type definitions and the underlying JavaScript stream implementations for XzFileStream and XzUncompressStream. These discrepancies lead to incorrect typings and non-standard Node.js stream usage patterns, which can hinder maintainability and lead to confusion for consumers of the library.
Sorry, something went wrong.
| }); | ||
| } | ||
|
|
||
| export class UncompressStream extends WriteStream { |
There was a problem hiding this comment.
The xz.UncompressStream is defined as extending WriteStream. However, its JavaScript implementation (lib/xz/uncompress_stream.js) pipes the decompressed data out of itself (decompressor.pipe(this)), making it behave as a Readable stream. To ensure type correctness and consistency with its runtime behavior, this type definition should extend ReadStream.
| export class UncompressStream extends WriteStream { | |
| export class UncompressStream extends ReadStream { |
Sorry, something went wrong.
| this.on('pipe', srcStream => { | ||
| srcStream.unpipe(this); | ||
| srcStream.pipe(compressor); | ||
| }); | ||
| } | ||
|
|
||
| _transform(chunk, encoding, callback) { | ||
| // This will be handled by the compressor stream | ||
| callback(); | ||
| } |
There was a problem hiding this comment.
The XzFileStream class extends stream.Transform, but its _transform method is a no-op, and the on('pipe') handler effectively bypasses the stream's writable side by redirecting the input directly to the internal compressor. This is an unconventional and misleading use of a Transform stream. If the stream is primarily intended to encapsulate a source and produce compressed output (as implied by index.d.ts defining it as ReadStream), it should extend stream.Readable and manage its input via opts.source or its _read method, without accepting piped input in this manner.
Sorry, something went wrong.
| this.on('pipe', srcStream => { | ||
| srcStream.unpipe(this); | ||
| srcStream.pipe(decompressor).pipe(this); | ||
| }); |
There was a problem hiding this comment.
Similar to XzFileStream, the on('pipe') handler in XzUncompressStream is problematic. If this stream is intended to be a Readable stream (as implied by the corrected index.d.ts type), it should not accept piped input in this manner. This pattern bypasses the stream's primary role and can lead to confusing behavior and misuse.
Sorry, something went wrong.
closes #96
All codes gen by cursor
Summary by CodeRabbit