ci: fix Node.js version for OIDC release + harden pipeline - #8
gxkl merged 2 commits into
Conversation
Sorry, something went wrong.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Sorry, something went wrong.
|
Warning Review limit reached@gxkl, you've reached your PR review limit, so we couldn't start this review. Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR. To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 636775b5-2969-4279-8abd-d7a530f0bf81 📥 CommitsReviewing files that changed from the base of the PR and between 2d167ba and b9c62bd. 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands. |
Sorry, something went wrong.
The release job set node-version 20 but installed npm@latest (npm 12), which requires Node.js >= 22.22.2, so `npm install -g npm@latest` failed with EBADENGINE. Node 20's bundled npm 10 also doesn't support OIDC trusted publishing (needs >= 11.5.1). Bump the release job to Node.js 24 and the checkout/setup-node actions to v5/v6 so npm@latest installs cleanly and supports trusted publishing.
Follow-ups from a pipeline review:
- release: add a concurrency group so two triggered releases can't race,
without cancelling an in-progress one
- release: skip the version bump on dry_run so a dry run has no side effects
- release: push to HEAD:${{ github.ref_name }} explicitly instead of HEAD
- test: also run Node.js 20 and 22 (kept 14/16/18); the package is released
on Node 24 but CI only tested up to 18
killagu
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Fixes the failed release run and applies pipeline-review follow-ups.
Release node version (the actual failure)
The release job set node-version: 20 but installed npm@latest (npm 12), which requires Node.js >= 22.22.2 — so Upgrade npm failed with EBADENGINE (run 29395807298). Node 20's bundled npm 10 also can't do OIDC trusted publishing (needs >= 11.5.1).
Hardening (from review)
Merging does not trigger a release (workflow_dispatch only). After merge, run the Release workflow with dry_run: true first to validate the pipeline, then with version_type: minor to cut 3.2.0 (requires the npm trusted publisher to be configured).