refactor: use new stream feature - #14
Open
XadillaX wants to merge 1 commit into
Open
XadillaX wants to merge 1 commit into
XadillaX wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
fengmk2
requested changes
Sep 18, 2018
fengmk2
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
全 stream 模式写还是得再改改
Sorry, something went wrong.
Comment thread
lib/formstream.js
|
|
||
| var ps = parseStream().pause(); | ||
| stream.pipe(ps); | ||
| if (this._isAllStreamSizeKnown) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
是否只需要 knownStreamSize 判断即可？
Sorry, something went wrong.
Comment thread
lib/formstream.js
|
|
||
| this._streams.push([leading, ps]); | ||
| if (options) { | ||
| for (const k in options) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
直接assign 即可，不需要考虑老的代码
Sorry, something went wrong.
Comment thread
lib/formstream.js
| }); | ||
|
|
||
| stream.on('data', data => { | ||
| this.push(data); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
这样不对的，formstream 一旦开始读，下游消费很慢，然后导致子 stream 数据全部被塞到内存里面了。这里应该也是得走 readable 模式，主动去读
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
还需要管理传入来的 stream 异常情况 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Requested changes must be addressed to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a big refactor.