FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add readCall/writeReply in V1.0 by tangzhi · Pull Request #58 · node-modules/hessian.js · GitHub

/ hessian.js Public

add readCall/writeReply in V1.0 - #58

Open
tangzhi wants to merge 3 commits into
node-modules:masterfrom
tangzhi:master
ConversationCommits (3)ChecksFiles changed
Open

add readCall/writeReply in V1.0#58
tangzhi wants to merge 3 commits into
node-modules:masterfrom
tangzhi:master

Conversation

tangzhi commented Jan 4, 2016

Copy link
Copy Markdown

在v1协议下增加了 readCall/writeReply等相关方法及测试代码。

codecov-io commented Jan 4, 2016

Copy link
Copy Markdown

Current coverage is 92.50%

Merging #58 into master will decrease coverage by -3.29% as of e442d5a

@@            master    #58   diff @@
=====================================
  Files            7      7       
  Stmts         1022   1028     +6
  Branches         0    171   +171
  Methods          0      0       
=====================================
- Hit            979    951    -28
- Partial          0     34    +34
  Missed          43     43

Review entire Coverage Diff as of e442d5a

Powered by Codecov. Updated on successful CI builds.

fengmk2 commented Jan 5, 2016

Copy link
Copy Markdown
Member

协议文档能发一下吗？

tangzhi commented Jan 6, 2016

Copy link
Copy Markdown
Author

http://hessian.caucho.com/doc/hessian-1.0-spec.xtp

fengmk2 commented Jan 6, 2016

Copy link
Copy Markdown
Member

好的，竟然之前没看到有这个功能。

fengmk2 reviewed Jan 6, 2016
View reviewed changes
Comment thread lib/v1/decoder.js Outdated

fengmk2 Jan 6, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this.byteBuffer.skip(1) 即可

fengmk2 self-assigned this Jan 6, 2016
dead-horse reviewed Jan 7, 2016
View reviewed changes
Comment thread lib/v1/decoder.js Outdated

dead-horse Jan 7, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this.byteBuffer.skip(1)

fengmk2 commented Mar 10, 2016

Copy link
Copy Markdown
Member

@tangzhi can you rebase from master and run ci test again?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

fengmk2

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL