FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

support for long.js by lishengguo · Pull Request #85 · node-modules/hessian.js · GitHub

/ hessian.js Public

support for long.js - #85

Open
lishengguo wants to merge 2 commits into
node-modules:masterfrom
lishengguo:master
ConversationCommits (2)ChecksFiles changed
Open

support for long.js#85
lishengguo wants to merge 2 commits into
node-modules:masterfrom
lishengguo:master

Conversation

lishengguo commented Aug 25, 2017

Copy link
Copy Markdown

writeLong(Long.fromValue(7))

support for long.js
1497770 
writeLong(Long.fromValue(7))

mention-bot commented Aug 25, 2017

Copy link
Copy Markdown

@lishengguo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @gxcsoccer and @xusiyuan841028 to be potential reviewers.

codecov Bot commented Aug 25, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #85 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master     #85   +/-   ##
======================================
  Coverage    96.1%   96.1%           
======================================
  Files           7       7           
  Lines        1079    1079           
  Branches      204     204           
======================================
  Hits         1037    1037           
  Misses         42      42
Impacted Files Coverage Δ
lib/v2/encoder.js 94.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8cfc6...83f6531. Read the comment docs.

fengmk2 commented Oct 18, 2017

Copy link
Copy Markdown
Member

any test cases?

lishengguo commented Oct 19, 2017

Copy link
Copy Markdown
Author

add test case : Long.fromNumber(0)

fengmk2 reviewed Aug 2, 2018
View reviewed changes
Comment thread lib/v2/encoder.js
*/
proto.writeLong = function (val) {
if (typeof val !== 'number' && utility.isSafeNumberString(val)) {
if (typeof val !== 'number' && utility.isSafeNumberString(val + '')) {

fengmk2 Aug 2, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

detect val is not equal string first.

if (typeof val !== 'number') {
  if (typeof val !== 'string') {
    val = val + '';
  }
  if (utility.isSafeNumberString(val)) {
    val = Number(val);
  }
}

fengmk2 added the bug label Aug 2, 2018

fengmk2 commented Aug 2, 2018

Copy link
Copy Markdown
Member

Please rebase from master branch.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fengmk2 fengmk2 left review comments

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL