FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

added category translation to google directions/geocoding & openweathermap by heikokue · Pull Request #278 · node-red/node-red-web-nodes · GitHub

  1. node-red
  2. node-red-web-nodes

Repository navigation

added category translation to google directions/geocoding & openweathermap - #278

Open
heikokue wants to merge 1 commit into
node-red:masterfrom
heikokue:category_translation
ConversationCommits (1)ChecksFiles changed
Open

added category translation to google directions/geocoding & openweathermap#278
heikokue wants to merge 1 commit into
node-red:masterfrom
heikokue:category_translation

Conversation

heikokue commented Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • [?] Bugfix (non-breaking change which fixes an issue)
  • [?] New feature (non-breaking change which adds functionality)

Proposed changes

  • added category translation to google directions/geocoding & openweathermap

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

coveralls commented Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown

Coverage remained the same at 71.026% when pulling 779a4fb on heikokue:category_translation into e0c0dd3 on node-red:master.

dceejay commented Mar 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

I know the fitbit api has been broken/changed for ages - not sure about the strava one.

We inherited the node-red-web-nodes from another group - and they are rarely maintained and not often used by ourselves. - So really not much point in updating them unless you have tested them.

thebaldgeek commented Mar 29, 2021 via email

Copy link
Copy Markdown

heikokue force-pushed the category_translation branch from a869f95 to 779a4fb Compare March 30, 2021 18:34
heikokue changed the title added category translation to fitbit, google directions/geocoding, op… added category translation to google directions/geocoding & openweathermap Mar 30, 2021

heikokue commented Mar 30, 2021

Copy link
Copy Markdown
Contributor Author

OK, I changed to only google directions/geocoding & openweathermap

heikokue commented Mar 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

please wait with bump!
the DE helps of google and openweathermap are still outstanding.
both nodes have quite high download rates...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL