FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Repo.mergebranches cleanup · Issue #868 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Repo.mergebranches cleanup #868

Open
Open
Repo.mergebranches cleanup#868

Description

maxkorp
opened on Jan 19, 2016

see #858
2 things to fix here with Repo.mergeBranches:

  • it should take a MergeOptions.
  • it might be able to use the preference stuff now, rather than explicitly going on way or the other, which would clean up significantly.
  • Add git_merge_analysis to our libgit2 doc supplement and use that in Repository#mergeBranches to clean up our manual implementation of that function.

Activity

  1. johnhaley81 commented on Jan 21, 2016

    johnhaley81
    on Jan 21, 2016
    Collaborator

    The preference stuff is used in git_merge_analysis which although is exposed via merge.h it doesn't show up in the API docs for some reason. We could supplement our own docs to manually add it and then actually use that call to clean up Repository#mergeBranches even more.

    Still, that would require MergePreferences still since that's not a part of MergeOptions https://libgit2.github.com/libgit2/#v0.23.4/type/git_merge_options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Back | FazBrowse Home | New Git URL