Descriptor fixes - #1004
Merged
johnhaley81 merged 2 commits intoApr 27, 2016
Merged
Descriptor fixes#1004johnhaley81 merged 2 commits into
johnhaley81 merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
generate/input/descriptor.json
| "types": | ||
| { | ||
| "annotated": { | ||
| "annotated_commit": { |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Can you remove this section completely? No use in having an empty section for this.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
Yes, but I fill it right back up in #1006.
Sorry, something went wrong.
Removing free from the list because it was not being honored anyway, and we have a test that uses this free
srajko
force-pushed
the
descriptor-fixes
branch
from
19d35eb to
5aa7822
Compare
April 27, 2016 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a couple of fixes to descriptors that I wanted to submit separately.