Fix submodules for the "no-prebuilt install from npm" case - #1026
Merged
johnhaley81 merged 2 commits intoMay 9, 2016
Merged
johnhaley81 merged 2 commits into
johnhaley81 merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Comment thread
lifecycleScripts/submodules/getStatus.js
Outdated
| return exec("git submodule status", { cwd: rootDir}) | ||
| .then(function(stdout) { | ||
| if (!stdout) { | ||
| // In the case where we pull from npm they pre-init the submoduels for |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
submo duels?
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
A legendary fight to the death where libgit2 211e11 is overcome by libgit2 c14853
Sorry, something went wrong.
As much as I like the idea of dueling submodules...
This was referenced Jun 5, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.