FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix tree entry leaks by srajko · Pull Request #1138 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Fix tree entry leaks #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 2 commits into from
Oct 7, 2016
Conversation 0 Commits 2 Checks 0 Files changed
Merged

Fix tree entry leaks #1138

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80937a3
Mark tree entry as selfFreeing
srajko Sep 7, 2016
0a707b0
Add tree entry leak test
srajko Sep 23, 2016
File filter

Filter by extension

Filter by extension .js  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Add tree entry leak test
  • Loading branch information
srajko committed Oct 7, 2016
commit 0a707b00a43d2d39109e37fae71b62a75245824f
13 changes: 13 additions & 0 deletions test/tests/tree_entry.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ var assert = require("assert");
var path = require("path");
var local = path.join.bind(path, __dirname);

var leakTest = require("../utils/leak_test");

describe("TreeEntry", function() {
var NodeGit = require("../../");
var Repository = NodeGit.Repository;
Expand Down Expand Up @@ -153,4 +155,15 @@ describe("TreeEntry", function() {
assert.equal(entry.isSubmodule(), false);
});
});

it("does not leak", function() {
var test = this;

return leakTest(NodeGit.TreeEntry, function() {
return test.commit.getTree()
.then(function(tree) {
return tree.entryByPath("example");
});
});
});
});
Back | FazBrowse Home | New Git URL