Fix CI failures on node 0.12 - #1144
Merged
johnhaley81 merged 1 commit intoOct 7, 2016
Merged
johnhaley81 merged 1 commit into
johnhaley81 merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
srajko
force-pushed
the
fix-travis-failure
branch
4 times, most recently
from
520825f to
4ca15bf
Compare
October 5, 2016 16:46
Copy link
Copy Markdown
Collaborator
Author
|
The failure with node 0.12 was happening after npm install, but it doesn't look like the failure was critical to the rest of the build. The fix I converged on ignores the npm install failure for node 0.12 (see comments in the yml file). If this is acceptable, I can squash this down to merge. |
Sorry, something went wrong.
srajko
force-pushed
the
fix-travis-failure
branch
2 times, most recently
from
36b9eaa to
68bab90
Compare
October 5, 2016 20:23
Revert "Use npm 2.15.11 with node 0.12" This reverts commit 9503b5c. Revert "Log npm-debug.log after failure" This reverts commit 412ce63. Remove ls attempt Ls purported npm-debug.log location and ignore npm install failure Attempt to cat npm-debug.log after install failure Log npm-debug.log after failure Use npm 2.15.11 with node 0.12
srajko
force-pushed
the
fix-travis-failure
branch
from
68bab90 to
8d69ff2
Compare
October 5, 2016 21:43
Copy link
Copy Markdown
Collaborator
|
This looks good to me. We're going to stop supporting 0.12 in December anyways since that's it's EOL but this will let us get to that mark at least. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.