Fix postinstall script crash when install location has spaces in its path - #1148
Merged
johnhaley81 merged 1 commit intoJan 27, 2017
Merged
johnhaley81 merged 1 commit into
johnhaley81 merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
johnhaley81
reviewed
Jan 27, 2017
Comment thread
lifecycleScripts/postinstall.js
| } | ||
|
|
||
| return exec("node " + path.join(rootPath, "dist/nodegit.js")) | ||
| return exec("node \"" + path.join(rootPath, "dist/nodegit.js\"")) |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I feel like return exec("node \"" + path.join(rootPath, "dist/nodegit.js\"")) should instead be return exec("node \"" + path.join(rootPath, "dist/nodegit.js") + "\"") but this has been open for long enough. I'll fix that in a later PR.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After installing nodegit in a directory which had spaces along its path, the postinstall script crashed as a result (Error: Cannot find module 'C:\<path up to the first space>') - wrapping this node call's target in quotes fixes the issue.