FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

escape the spaces in dir for shell command by iloahz · Pull Request #1186 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

escape the spaces in dir for shell command - #1186

Merged
johnhaley81 merged 1 commit into
nodegit:masterfrom
iloahz:master
Jan 27, 2017
ConversationCommits (1)ChecksFiles changed
Merged

escape the spaces in dir for shell command#1186
johnhaley81 merged 1 commit into
nodegit:masterfrom
iloahz:master

Conversation

iloahz commented Jan 10, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This should fix the issue in #1082

jmshal commented Jan 25, 2017 •
edited
Loading

Copy link
Copy Markdown

I'm hoping this can be merged in soon. Sadly I need this for my build system to work correctly.

Edit: I ended up ditching nodegit, because it also seemed just a bit too heavy to include with my module.

johnhaley81 mentioned this pull request Jan 27, 2017
Open

johnhaley81 commented Jan 27, 2017

Copy link
Copy Markdown
Collaborator

Thanks @iloahz.

Sorry that NodeGit didn't work for you @jacobmarshall. It is pretty big so I can understand it not fitting into your use case.

johnhaley81 merged commit 19225ef into nodegit:master Jan 27, 2017

jmshal commented Jan 27, 2017

Copy link
Copy Markdown

Sorry that NodeGit didn't work for you @jacobmarshall. It is pretty big so I can understand it not fitting into your use case.

Thanks @johnhaley81, I seriously appreciate your work. nodegit is a beautifully eloquent library. I look forward to using it in the future.

johnhaley81 commented Jan 27, 2017

Copy link
Copy Markdown
Collaborator

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL