Specify acceptable types for lookup and dwim in Reference - #1203
Merged
maxkorp merged 1 commit intoJan 30, 2017
Merged
maxkorp merged 1 commit into
maxkorp merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Make it clear to the client that only Commits and Tags are valid parameters.
Copy link
Copy Markdown
Member
Author
|
JSHint's character restriction per line meant I had to make more changes to the reset.js beyond just simply modifying the @param tag. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
<3 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to libgit2's APIs, only git_commits and git_tags are acceptable. Update the documentation to accurately reflect this instead of just taking in an Object.
https://libgit2.github.com/libgit2/#HEAD/group/reset/git_reset
https://libgit2.github.com/libgit2/#HEAD/group/reset/git_reset_default