Write the index to a repository directly in merge-cleanly.js examples - #1205
Merged
maxkorp merged 1 commit intoJan 30, 2017
Merged
maxkorp merged 1 commit into
maxkorp merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The returned Index from Merge.commits() doesn't know where to write the index to because it is not backed by a repository. This prevents the example from running because the write() fails as it's only in-memory and has no notion of a target .git/index file. Skip the write() and just use writeTreeTo() immediately instead to write the index to the sample repository.
rcjsuen
force-pushed
the
merge-cleanly
branch
from
9f5a9ca to
c0a8d97
Compare
January 29, 2017 00:49
Copy link
Copy Markdown
Collaborator
|
Excellent find. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1128. The returned index is only in-memory and doesn't know where to write the .git/index file to so we should just skip the write() call and to just only use writeTreeTo() instead.