Initialize pointers to fix compiler warnings about uninitialized local variables - #1210
Merged
johnhaley81 merged 1 commit intoFeb 26, 2017
Merged
johnhaley81 merged 1 commit into
johnhaley81 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
In convert_from_v8.cc, the unwrapping of values uses two separate lines of code for variable declaration and variable assignment. When a pointer (or double pointer) is present, the assignment to the newly declared variable creates a compiler warning. To prevent the compilation logs from filling up unnecessarily, pointer variables should initially be assigned a `NULL` value upon its declaration so that the compiler will not emit a warning on the subseqent variable assignment line.
Copy link
Copy Markdown
Collaborator
|
The compiler warnings have been bugging me for awhile. Thanks for fixing some of them! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling the C++ bridge code, you will see several warnings about the use of uninitialized variables.
Linux / OSX
../src/config.cc:376:2: warning: variable 'from_tx' is uninitialized when used here [-Wuninitialized] *from_tx = Nan::ObjectWrap::Unwrap<GitTransaction>(info[0]->ToObject())->GetValue(); ^~~~~~~ ../src/config.cc:375:29: note: initialize the variable 'from_tx' to silence this warning git_transaction ** from_tx; ^ = nullptrWindows
The warnings above can easily be fixed by initializing these pointer variables to NULL. We should strive to have as few warnings as possible in the code (if not zero) to make the compilation logs more readable by improving the signal to noise ratio wherever possible.