Add regression test for libgit2 #4102 - #1220
Closed
rcjsuen wants to merge 1 commit into
Closed
rcjsuen wants to merge 1 commit into
rcjsuen wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Using a Revwalk.SORT.TOPOLOGICAL in a revwalk is causing libgit2 to crash. This regression test should help ensure this bug is covered by the test suite in the future.
Copy link
Copy Markdown
Member
Author
|
The test is crashing early as expected (since the Revwalk tests are the last one it executes) but the 0 exit code is flagging the builds as green on Travis. Hm... The command "if [ $TARGET_ARCH == "x64" ]; then if [ -z "$TRAVIS_TAG" ] && [ $TRAVIS_OS_NAME == "linux" ] && [ $NODE_VERSION == "6" ]; then npm test && npm run cov && npm run coveralls; else npm test; fi else echo "Not running tests because the binary is not built for 64-bit systems"; fi" exited with 0. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
please rebase and reopen if still relevant |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Revwalk.SORT.TOPOLOGICAL is used in a revwalk, Node will crash. This is caused by libgit #4102.
This is blocking the Orion project from upgrading to NodeGit 0.17.0.