Provide rebase details on finish - #1224
Merged
johnhaley81 merged 3 commits intoFeb 28, 2017
Merged
johnhaley81 merged 3 commits into
johnhaley81 merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
When using the convenience methods for rebase, we should return all the details about the rebase before finishing. This includes the sha translation map for the rebase operation, and other meta data (old head sha, branch names, new head sha)
Copy link
Copy Markdown
Member
Author
|
Destructuring on node4 + coverage tool = broken. |
Sorry, something went wrong.
johnhaley81
reviewed
Feb 28, 2017
Comment thread
test/tests/rebase.js
Outdated
| var fse = promisify(require("fs-extra")); | ||
|
|
||
| describe("Rebase", function() { | ||
| describe.only("Rebase", function() { |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
This needs to be removed
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
This is literally the most important function 👍
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the convenience methods for rebase, we should return all the details about the rebase before finishing. This includes the sha translation map for the rebase operation, and other meta data (old head sha, branch names, new head sha).
This is a breaking API change.