Add JavaScript version of git_tag_peel() - #1269
Merged
cjhoward92 merged 1 commit intoDec 20, 2017
Merged
cjhoward92 merged 1 commit into
cjhoward92 merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The git_tag_peel() function from libgit2 naturally takes a pointer as a parameter for providing the caller with the peeled object. However, this kind of API does not make sense in the JavaScript world so we need to change the generated code to return the actual object to the caller.
cjhoward92
approved these changes
Dec 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated code for git_tag_peel() is taking a pointer as a to return the peeled object. We should change the argument to be isReturn so that the generated API is sane from a JavaScript point of view.