FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove unnecessary assignment of Commit#repo by tniessen · Pull Request #1508 · nodegit/nodegit · GitHub

/ nodegit Public

Remove unnecessary assignment of Commit#repo - #1508

Merged
tbranyen merged 1 commit into
nodegit:masterfrom
tniessen:repository-remove-unnecessary-assignment
Jan 19, 2020
ConversationCommits (1)ChecksFiles changed
Merged

Remove unnecessary assignment of Commit#repo#1508
tbranyen merged 1 commit into
nodegit:masterfrom
tniessen:repository-remove-unnecessary-assignment

Conversation

tniessen commented Jun 6, 2018

Copy link
Copy Markdown
Contributor

Repository#getCommit uses Commit.lookup and then manually assigns to Commit#repo even though Commit.lookup already does that. There is no way for Commit.lookup to return a Commit without a repo property.

tniessen commented Jun 22, 2018

Copy link
Copy Markdown
Contributor Author

Ping @tbranyen, @johnhaley81, @maxkorp.

tniessen commented Jan 19, 2020

Copy link
Copy Markdown
Contributor Author

It's been far more than a year, please close this if you do not want to merge it.

tbranyen commented Jan 19, 2020

Copy link
Copy Markdown
Member

Tests aren't passing and the CI is failing. We can't merge it like this. Please correct the issues or ask for help and we can get this merged if it's still needed.

tniessen commented Jan 19, 2020

Copy link
Copy Markdown
Contributor Author

@tbranyen If I remember correctly, the failures were due to problems on your side, not on mine, and CI last ran two years ago on this. But sure, I will rebase and force-push to cause a new CI run.

Remove unnecessary assignment of Commit#repo
c2b61a2 
Repository#getCommit uses Commit.lookup and then manually assigns
to Commit#repo even though Commit.lookup already does that.
tniessen force-pushed the repository-remove-unnecessary-assignment branch from 112317f to c2b61a2 Compare January 19, 2020 18:47

tniessen commented Jan 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

My patch seems to be working fine, so it must have been problems with your existing code or your CI setup.

tbranyen commented Jan 19, 2020

Copy link
Copy Markdown
Member

Looks good 👍, thanks for getting the PR into a mergeable state.

tbranyen merged commit b111960 into nodegit:master Jan 19, 2020
snyk-bot mentioned this pull request Apr 22, 2020
Open
snyk-bot mentioned this pull request May 5, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL