Fix behavior of Commit#parent - #1509
Merged
implausible merged 1 commit intoJan 21, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ping @tbranyen, @johnhaley81, @maxkorp. |
Sorry, something went wrong.
implausible
previously requested changes
Jul 16, 2018
Comment thread
lib/commit.js
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@implausible Sorry for the late reply. Is the new commit better? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ping @implausible, it's been far more than a year, is this still a helpful PR? If not, please close it. |
Sorry, something went wrong.
Commit#parent did not assign the repo property so subsequent calls which relied on this property (such as Commit#getTree) failed. This change works around this problem by imitating what LookupWrapper does for Commit.lookup, that is, it wraps the actual call in a new function and manually assigns the repo property.
tniessen
force-pushed
the
fix-commit-parent-no-repo-prop
branch
from
a84df76 to
e3bb744
Compare
January 19, 2020 19:01
implausible
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit#parent did not assign the repo property so subsequent calls which relied on this property (such as Commit#getTree) failed. This change works around this problem by imitating what LookupWrapper does for Commit.lookup, that is, it wraps the actual call in a new function and manually assigns the repo property.
This commit also adds a test case for the corrected behavior.