Remove ssl and crypto dependency on non-electron builds - #1600
Merged
implausible merged 1 commit intoDec 20, 2018
Merged
implausible merged 1 commit into
implausible merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Dec 17, 2018
implausible
force-pushed
the
bug/ssl-not-required-for-node-builds
branch
from
e52ab8a to
4b5d313
Compare
December 20, 2018 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node should actually satisfy both of these links, because it actually exposes the headers for them. This isn't the case in Electron. This should hopefully solve some prebuilt issues regarding the various linuxes.