| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
Thanks for your help! Would you please fix the indentation in these in your promise methods and consider adjusting the flow of your promise chain as I've suggested in my review?
Sorry, something went wrong.
There was a problem hiding this comment.
@implausible Updated
Sorry, something went wrong.
|
@implausible I've seen the change requested. I not entirely understand what your "fix the indentation" means, could you explain it more precisely? |
Sorry, something went wrong.
|
Hrmm.. So upon further review of this code, I noticed that the current patch is proposing to run yarn install --ignore-scripts, but I think this is actually irrelevant. If you follow the code, we perform npm -v to check if the version of npm is less than 2, and then we run npm install --ignore-scripts. For all versions npm@3 and above, we don't run an install script. I believe that yarn's behavior will mirror that of npm@3's behavior, and we shouldn't need to run yarn install --ignore-scripts at all. I think the patch that we're actually looking for looks like this: Can you confirm this solves your issue? |
Sorry, something went wrong.
|
Closed in favor of #1644 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
No description provided.