Add additional getters to streamline information gathering (breaking change) - #1671
Merged
implausible merged 8 commits intoMay 3, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
getRemotes has been renamed to getRemotes and getRemotes is now a method that returns the remotes for a repository
Reset baton->error_code to GIT_OK on clean loop exit. Use \\s instead of \s for regex string
7 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some getters are of particular concern to GitKraken, others have obvious utility to anyone getting many references or doing a commit walk.
This is breaking because getRemotes has been renamed to getRemoteNames, and now getRemotes returns remotes instead of strings.