Remote needs to persist the callback/proxyOpts/headers - #1784
Merged
implausible merged 1 commit intoJul 28, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
themadtitanmathos
force-pushed
the
fix/remote-callbacks-pointer-cleanup
branch
from
481b574 to
d5ad62c
Compare
July 28, 2020 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing a segfault (sometimes) while pushing using connect/upload/disconnect. v8 was releasing the pointers to the options after the call to connect. When upload tries to reuse those pointers, they need to have survived until the remote is disconnected.