FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Better installation flow for developing. by tbranyen · Pull Request #180 · nodegit/nodegit · GitHub

Repository navigation

Better installation flow for developing. - #180

Merged
3y3 merged 3 commits into
masterfrom
better-flow
Jun 20, 2014
Merged

3y3 merged 3 commits into
masterfrom
better-flow

Conversation

Copy link
Copy Markdown
Member
  • Detects if libgit2 is already fetched instead of constantly fetching.
  • Removes outdated libgit2 files.
  • Provides more meta information about libgit2 inside package.json.

tbranyen added 2 commits June 20, 2014 14:32
- Detects if libgit2 is already fetched instead of constantly fetching.
- Provides more meta information about libgit2 inside package.json.

3y3 commented Jun 20, 2014

Copy link
Copy Markdown
Contributor

About fetching libgit2: is it possible what fetched library has old uncompatible version?

Copy link
Copy Markdown
Member Author

Yes, that is a good point. What would you suggest to handle this? Should I write out a tracking file named something like sha that contains the currently installed sha? That way we can compare and wipe out if it's outdated.

Copy link
Copy Markdown
Member Author

Actually I could just write a file named identical to the sha and fs.stat that for testing.

3y3 commented Jun 20, 2014

Copy link
Copy Markdown
Contributor

I think, will be enough to parse ./vendor/libgit2/include/git2/version.h

3y3 commented Jun 20, 2014

Copy link
Copy Markdown
Contributor

Your solution will be simple

tbranyen changed the title Better flow for development. Better installation flow for developing. Jun 20, 2014

Copy link
Copy Markdown
Member Author

If this looks good to you @3y3 can you merge?

Comment thread package.json Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Where is used pkg.libgit2.libgit2?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nowhere, must be remnant from something else. Good catch, removed.

3y3 commented Jun 20, 2014

Copy link
Copy Markdown
Contributor

Ok, I'm ready to merge it.
I have question about checking python current realisation working fine, but if exclude users of python 1.*(seriously dinosaurs knows about github?), the checking can be simplified.

Copy link
Copy Markdown
Member Author

@3y3 the checking is between python2 and python3 not python1. On systems like Arch Linux python defaults to 3 which doesn't work here. python2 is the aliased form.

3y3 added a commit that referenced this pull request Jun 20, 2014
Better installation flow for developing.
3y3 merged commit 8613a3e into master Jun 20, 2014

3y3 commented Jun 20, 2014

Copy link
Copy Markdown
Contributor

Oh - now it's clearly. Merged.

Copy link
Copy Markdown
Member Author

Awesome, thanks!

tbranyen deleted the better-flow branch June 20, 2014 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL