FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update Readme, to improve example code by nmn · Pull Request #248 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Update Readme, to improve example code - #248

Merged
tbranyen merged 1 commit into
nodegit:masterfrom
nmn:patch-1
Oct 22, 2014
ConversationCommits (1)ChecksFiles changed
Merged

Update Readme, to improve example code#248
tbranyen merged 1 commit into
nodegit:masterfrom
nmn:patch-1

Conversation

nmn commented Oct 22, 2014

Copy link
Copy Markdown
Contributor

Refactored code to use promises chaining for more clarity and less callback hell.

Update Readme, to improve example code
f417c18 
Refactored code to use promises chaining for more clarity and less callback hell.

tbranyen commented Oct 22, 2014

Copy link
Copy Markdown
Member

Ha, I was just thinking of doing this myself. Thanks!

tbranyen reviewed Oct 22, 2014
View reviewed changes
Comment thread README.md

tbranyen Oct 22, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like some extra space here.

nmn Oct 22, 2014

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There were some lines already, I left extra spaces before every comment. That's just a style choice. You can make the call.

tbranyen Oct 22, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nope, if you look at the diff the comment aligned with console. Now it's off by a few. Sorry if I wasn't clear.

tbranyen commented Oct 22, 2014

Copy link
Copy Markdown
Member

No worries, I'll fix the whitespace issue. Thanks for the contribution!

tbranyen added a commit that referenced this pull request Oct 22, 2014
Merge pull request #248 from naman34/patch-1
677f4d7 
Update Readme, to improve example code
tbranyen merged commit 677f4d7 into nodegit:master Oct 22, 2014

nmn commented Oct 22, 2014

Copy link
Copy Markdown
Contributor Author

Sorry I missed that.

—
Sent from Mailbox

On Wed, Oct 22, 2014 at 8:50 PM, Tim Branyen notifications@github.com
wrote:

Merged #248.

Reply to this email directly or view it on GitHub:
#248 (comment)

tbranyen commented Oct 22, 2014

Copy link
Copy Markdown
Member

NP it was just a whitespace issue

nmn deleted the patch-1 branch November 11, 2014 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL