FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Added ability for callbacks to poll promises for fulfillment value by johnhaley81 · Pull Request #260 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Added ability for callbacks to poll promises for fulfillment value - #260

Merged
johnhaley81 merged 4 commits into
masterfrom
callback-promises
Nov 11, 2014
ConversationCommits (4)ChecksFiles changed
Merged

Added ability for callbacks to poll promises for fulfillment value#260
johnhaley81 merged 4 commits into
masterfrom
callback-promises

Conversation

johnhaley81 commented Oct 28, 2014

Copy link
Copy Markdown
Collaborator

This will allow a callback native to libgit2 to actually have a promise value be returned in the callback eventually. We'll be able to not pause the JS thread while we wait for authentication or any other callback that is triggered from the V8 side.

johnhaley81 commented Oct 28, 2014

Copy link
Copy Markdown
Collaborator Author

This will need then/promise#58 to be fixed in order for it to work. If they refuse that pull request we might need to switch libraries.

tbranyen reviewed Oct 30, 2014
View reviewed changes
Comment thread test/tests/cred.js

tbranyen Oct 30, 2014

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need to return Promises within the tests

tbranyen commented Nov 8, 2014

Copy link
Copy Markdown
Member

We may want to consider using https://github.com/zenparsing/v8-promise instead. This will more closely model the construct we'll use once Node 0.12 lands.

A note: we should also coerce all inbound Promises to this implementation using Promise.cast.

maxkorp mentioned this pull request Nov 10, 2014
Closed

johnhaley81 commented Nov 10, 2014

Copy link
Copy Markdown
Collaborator Author

v8-promise doesn't have sync-polling of a promise however. :(

johnhaley81 commented Nov 10, 2014

Copy link
Copy Markdown
Collaborator Author

I'm leaning towards Q right now. It seems like it could slip into promisify-node pretty easily and has the sync polling that we need. What do you think @tbranyen?

johnhaley81 force-pushed the callback-promises branch 2 times, most recently from e3c1df1 to 356bccc Compare November 11, 2014 21:58

johnhaley81 commented Nov 11, 2014

Copy link
Copy Markdown
Collaborator Author

We finally settled on forking then/promise into a new repo nodegit/promise and using that in promisify-node.

tbranyen commented Nov 11, 2014

Copy link
Copy Markdown
Member

This makes me wonder if we should keep promisify-node generic and fork it to nodegit as well?

johnhaley81 commented Nov 11, 2014

Copy link
Copy Markdown
Collaborator Author

We can do that. Keep all of nodegit's stuff in this org.

johnhaley81 added a commit that referenced this pull request Nov 11, 2014
Merge pull request #260 from nodegit/callback-promises
83ee7e0 
Added ability for callbacks to poll promises for fulfillment value
johnhaley81 merged commit 83ee7e0 into master Nov 11, 2014
johnhaley81 deleted the callback-promises branch November 11, 2014 23:20
johnhaley81 restored the callback-promises branch November 12, 2014 00:54

maxkoryukov commented May 25, 2016

Copy link
Copy Markdown

I still don't understand, why not to use the Bluebird-lib?

johnhaley81 commented May 25, 2016

Copy link
Copy Markdown
Collaborator Author

This PR is superseded by #854

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL