[WIP] Better installation flow - #287
Merged
tbranyen merged 7 commits intoNov 25, 2014
Merged
tbranyen merged 7 commits into
tbranyen merged 7 commits into
Conversation
tbranyen
force-pushed
the
better-install-process
branch
2 times, most recently
from
47fd603 to
4d10ce3
Compare
November 22, 2014 04:26
Copy link
Copy Markdown
Collaborator
|
So, appveyor failed, but travis seems to think it's ok. |
Sorry, something went wrong.
tbranyen
force-pushed
the
better-install-process
branch
from
252f31d to
0e5b78e
Compare
November 24, 2014 19:16
johnhaley81
force-pushed
the
better-install-process
branch
from
5757fd7 to
40c6510
Compare
November 24, 2014 23:41
Also added in --build-only stub, will fill in later
By default the module will attempt to install from a prebuilt binary from S3. If this fails it will attempt a native compile. For our continuous integration and local development we'll always run with `BUILD_ONLY=true`.
Can determine environment and which flags should be set. Will fix expose-gc bug in Windows. Test coverage reports have been moved to the test folder and the gitignore is updated accordingly.
johnhaley81
force-pushed
the
better-install-process
branch
from
40c6510 to
c4aa958
Compare
November 24, 2014 23:44
tbranyen
added a commit
that referenced
this pull request
Nov 25, 2014
[WIP] Better installation flow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.