Removed references to node_events.h - #31
Closed
alexkwolfe wants to merge 1 commit into
Closed
alexkwolfe wants to merge 1 commit into
alexkwolfe wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…ary for Node 0.5.x compatibility.
Copy link
Copy Markdown
Author
|
Pretty sure this pull request resolves the aforementioned issue on node > 0.5.3: #30 |
Sorry, something went wrong.
Copy link
Copy Markdown
|
When you include node.h, all the other Node headers are also included. Update: Just noticed that only object_wrap and other internals are included. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Project compiles on ~0.8, closing. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks to me like this solves the compilation problem through 0.5.3 that was caused by the removal of node_events.h from node.js. Same tests pass/fail before and after this change.