FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix 313 generate scripts by graycodes · Pull Request #315 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Fix 313 generate scripts - #315

Merged
maxkorp merged 3 commits into
nodegit:masterfrom
graycodes:fix-313-generate-scripts
Dec 5, 2014
ConversationCommits (3)ChecksFiles changed
Merged

Fix 313 generate scripts#315
maxkorp merged 3 commits into
nodegit:masterfrom
graycodes:fix-313-generate-scripts

Conversation

graycodes commented Dec 4, 2014

Copy link
Copy Markdown
Contributor

Updated the contributing file to reflect script changes.
Updated each generate script to pass an IIFE to module.exports.
Updated generate/index.js to account for the above.

johnhaley81 commented Dec 4, 2014

Copy link
Copy Markdown
Collaborator

Going to wait for 310 to finish before we merge this in.

maxkorp commented Dec 5, 2014

Copy link
Copy Markdown
Collaborator

Hey, now that 310 is merged in, if you can rebase this up on top of master we can go ahead and merge it in.

graycodes force-pushed the fix-313-generate-scripts branch from 3b4d950 to 3006ad2 Compare December 5, 2014 07:31

graycodes commented Dec 5, 2014

Copy link
Copy Markdown
Contributor Author

Rebased against master. Waiting for build.

maxkorp mentioned this pull request Dec 5, 2014
Closed

maxkorp commented Dec 5, 2014

Copy link
Copy Markdown
Collaborator

I'm calling this passing and merging it in. See #316

maxkorp added a commit that referenced this pull request Dec 5, 2014
Merge pull request #315 from xinUmbralis/fix-313-generate-scripts
e3216b4 
Fix 313 generate scripts
maxkorp merged commit e3216b4 into nodegit:master Dec 5, 2014

maxkorp commented Dec 5, 2014

Copy link
Copy Markdown
Collaborator

Thanks for the help @xinumbralis!!

graycodes commented Dec 5, 2014

Copy link
Copy Markdown
Contributor Author

No worries at all! I'll get started on the tests before long.

graycodes deleted the fix-313-generate-scripts branch December 5, 2014 14:49

johnhaley81 commented Dec 5, 2014

Copy link
Copy Markdown
Collaborator

This fixes #313

johnhaley81 commented Dec 5, 2014

Copy link
Copy Markdown
Collaborator

Very much appreciated @xinumbralis!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL