FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update appveyor.yml to remove project id by vladikoff · Pull Request #324 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

Update appveyor.yml to remove project id - #324

Merged
tbranyen merged 1 commit into
nodegit:masterfrom
vladikoff:patch-1
Dec 9, 2014
ConversationCommits (1)ChecksFiles changed
Merged

Update appveyor.yml to remove project id#324
tbranyen merged 1 commit into
nodegit:masterfrom
vladikoff:patch-1

Conversation

vladikoff commented Dec 9, 2014

Copy link
Copy Markdown
Contributor

No description provided.

tbranyen commented Dec 9, 2014

Copy link
Copy Markdown
Member

Do we just not need the id or why was this removed?

vladikoff commented Dec 9, 2014

Copy link
Copy Markdown
Contributor Author

From the support email Recent AppVeyor update added strict YAML schema validation."
so it seems like we need to update our YAMLs. Lets see if the build passes

tbranyen commented Dec 9, 2014

Copy link
Copy Markdown
Member

@vladikoff can you remove the slack integration from appveyor to see if it triggers a pass?

vladikoff commented Dec 9, 2014

Copy link
Copy Markdown
Contributor Author

Updated

johnhaley81 commented Dec 9, 2014

Copy link
Copy Markdown
Collaborator

@vladikoff could you include the relevant part of the email explaining why the project id isn't needed anymore please?

tbranyen commented Dec 9, 2014

Copy link
Copy Markdown
Member

Awesome, looks like that worked! Thanks @vladikoff.

@johnhaley81 relevant URL: appveyor/ci#1 (comment)

tbranyen closed this Dec 9, 2014

tbranyen commented Dec 9, 2014

Copy link
Copy Markdown
Member

F! I'll manually merge.

Nevermind...

tbranyen reopened this Dec 9, 2014
tbranyen added a commit that referenced this pull request Dec 9, 2014
Merge pull request #324 from vladikoff/patch-1
a65ff08 
Update appveyor.yml to remove project id
tbranyen merged commit a65ff08 into nodegit:master Dec 9, 2014
vladikoff deleted the patch-1 branch December 9, 2014 18:59
johnhaley81 mentioned this pull request Jan 5, 2015
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL