FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update dependency fs-extra to ~0.14.0 by PeterDaveHello · Pull Request #343 · nodegit/nodegit · GitHub

Repository navigation

Update dependency fs-extra to ~0.14.0 - #343

Merged
johnhaley81 merged 1 commit into
nodegit:masterfrom
PeterDaveHello:patch-2
Jan 13, 2015
Merged

johnhaley81 merged 1 commit into
nodegit:masterfrom
PeterDaveHello:patch-2

Conversation

Copy link
Copy Markdown
Contributor

Looks like nodegit works fine with fs-extra v0.14, would you like to merge this PR, thanks.

Copy link
Copy Markdown
Collaborator

Thanks for bumping fs-extra :)

johnhaley81 added a commit that referenced this pull request Jan 13, 2015
Update dependency fs-extra to ~0.14.0
johnhaley81 merged commit 0f2ed01 into nodegit:master Jan 13, 2015
PeterDaveHello deleted the patch-2 branch January 13, 2015 17:58

Copy link
Copy Markdown
Contributor Author

Thanks!

Copy link
Copy Markdown
Contributor Author

FYI, cdnjs's git auto-updater(https://github.com/cdnjs/autoupdate) not work properly after fs-extra v0.12 (I meant v0.13/0.14), we should still be careful here(I'm not sure if the CI test covered 100% codes).

Copy link
Copy Markdown
Collaborator

The only thing we actually use fs-extra for is generating the code on a platform that we don't already have a pre-built binary up on S3 and for running tests. So it's not actually used in production at all (hopefully) but just for dev. It should be moved into the dev dependancies but we had some problems in the past with doing that. We'll have to take a closer look at all of our dev dependancies after @maxkorp finishes some of our npm install script work.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL