FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

WIP: Refactor publishing by maxkorp · Pull Request #350 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

WIP: Refactor publishing - #350

Closed
maxkorp wants to merge 16 commits into
masterfrom
refactor-publishing
ConversationCommits (16)ChecksFiles changed
Closed

WIP: Refactor publishing#350
maxkorp wants to merge 16 commits into
masterfrom
refactor-publishing

Conversation

maxkorp commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator

So I've done quite a bit here.

  • First of all, we've minimized the dependency list for normal non dev installs.
  • If the install happens from the NPM registry, we clean up after ourselves (cuts size by ~50%) including some extra dependencies (takes us well over 50% savings).
  • Added the option to do a debug build using BUILD_DEBUG=1, and a shorthand npm run buildDebug
  • Moved node-webkit detection to an outside module
  • made it so generate scripts can be called on the command line, but require returns a function, rather than taking immediate effect.
  • moved all scripts out of the root directory and in to lifecyclescripts
  • prepublish step also downloads vendor deps, since those are now published.

maxkorp changed the title Refactor publishing WIP: Refactor publishing Jan 14, 2015
maxkorp force-pushed the refactor-publishing branch from e6c5819 to 7258070 Compare January 14, 2015 19:01

maxkorp commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator Author

So I'm trying to figure out why this fails on linux 10, something with content type headers not being set...
Definitely pretty confused.

mcollina commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator

👍, but bump the minor version number when you release it. If it introduces the smallest bug, it will trouble people that depends on ~0.2.4. I suggest keeping this new 0.3 release in a new branch, just to simplify life for newcomers to the project, and merge when it is all done.

maxkorp commented Jan 14, 2015

Copy link
Copy Markdown
Collaborator Author

I'm fine pushing it to an 0.3.0. Might be time for that bump soon anyways with the libgit changes from upstream.

maxkorp force-pushed the refactor-publishing branch 5 times, most recently from 2dfad62 to 6188842 Compare January 16, 2015 18:20

maxkorp commented Jan 16, 2015

Copy link
Copy Markdown
Collaborator Author

During the refactor a version check got missed, which usually caused a different version of http_parser to get pulled in for v10. That wasnt happening, causing a mismatch.

maxkorp force-pushed the refactor-publishing branch 3 times, most recently from cc3e106 to d4bbb04 Compare January 19, 2015 19:34
maxkorp force-pushed the refactor-publishing branch from d4bbb04 to cad078e Compare January 19, 2015 19:52

maxkorp commented Jan 19, 2015

Copy link
Copy Markdown
Collaborator Author

Making a new PR for the 0.3 branch.

maxkorp closed this Jan 19, 2015
snyk-bot mentioned this pull request Jul 17, 2020
Open
jmatsushita mentioned this pull request Jun 29, 2022
Open
takeratta mentioned this pull request Nov 28, 2023
Open
jmatsushita mentioned this pull request Dec 19, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL