Updated to nan 1.5.0 and fixed build errors - #351
Merged
johnhaley81 merged 1 commit intoJan 15, 2015
Merged
johnhaley81 merged 1 commit into
johnhaley81 merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
In nan 1.5.0 NanNew does a less-greedy matching for its overloads so the 2 `New` functions caused a build error so I renamed the one meant for the js side to `jsNewFunction`. I'm hoping that's clear enough.
Copy link
Copy Markdown
Member
|
Woo, is this good to merge ya think? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
Yeah, I think this is good to merge. I'm curious as to why the appveyor passed this time though. Still trying to figure out why we have it die during clone so often. I feel like it's a timing thing. |
Sorry, something went wrong.
johnhaley81
added a commit
that referenced
this pull request
Jan 15, 2015
Updated to nan 1.5.0 and fixed build errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In nan 1.5.0 NanNew does a less-greedy matching for its
overloads so the 2 New functions caused a build error so
I renamed the one meant for the js side to jsNewFunction.
I'm hoping that's clear enough.