FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] Attempt at fixing appveyor by johnhaley81 · Pull Request #352 · nodegit/nodegit · GitHub

  1. nodegit
  2. nodegit

Repository navigation

[WIP] Attempt at fixing appveyor - #352

Merged
johnhaley81 merged 2 commits into
masterfrom
fix-appveyor
Jan 19, 2015
ConversationCommits (2)ChecksFiles changed
Merged

[WIP] Attempt at fixing appveyor#352
johnhaley81 merged 2 commits into
masterfrom
fix-appveyor

Conversation

johnhaley81 commented Jan 15, 2015

Copy link
Copy Markdown
Collaborator

The clone tests are breaking appveyor and this PR is my attempt to figure out why since I can't consistently repo the test fails locally.

johnhaley81 mentioned this pull request Jan 15, 2015
Closed
johnhaley81 force-pushed the fix-appveyor branch 4 times, most recently from b7285a2 to 9320789 Compare January 16, 2015 16:30
tbranyen reviewed Jan 16, 2015
View reviewed changes
Comment thread test/tests/clone.js

tbranyen Jan 16, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fix is probably not the right word here 😜

johnhaley81 commented Jan 17, 2015

Copy link
Copy Markdown
Collaborator Author

So something is legit killing the the build for node v0.11.14 on windows. Which is awesome since it was working fine yesterday.

I've started to narrow it down. The build is fine in v0.11.13 but will break in v0.11.14 on windows only. I don't know if a dev dependency got updated (or needs to be updated) for this to work in v0.11.14 but I'm still looking into it.

johnhaley81 commented Jan 17, 2015

Copy link
Copy Markdown
Collaborator Author

It seems like a bug in node-gyp when running node-gyp configure it tries to download a file (node.lib) and has a non-matching checksum.

I get this output from the console

C:\git-projects\nodegit (master)                                                                                                                                                                     
λ node-gyp configure                                                                                                                                                                                 
gyp info it worked if it ends with ok                                                                                                                                                                
gyp info using node-gyp@1.0.2                                                                                                                                                                        
gyp info using node@0.11.14 | win32 | x64                                                                                                                                                            
gyp http GET http://nodejs.org/dist/v0.11.14/node-v0.11.14.tar.gz                                                                                                                                    
gyp http 200 http://nodejs.org/dist/v0.11.14/node-v0.11.14.tar.gz                                                                                                                                    
gyp http GET http://nodejs.org/dist/v0.11.14/SHASUMS256.txt                                                                                                                                          
gyp http GET http://nodejs.org/dist/v0.11.14/x64/node.lib                                                                                                                                            
gyp http GET http://nodejs.org/dist/v0.11.14/node.lib                                                                                                                                                
gyp http 200 http://nodejs.org/dist/v0.11.14/SHASUMS256.txt                                                                                                                                          
gyp http 200 http://nodejs.org/dist/v0.11.14/x64/node.lib                                                                                                                                            
gyp http 200 http://nodejs.org/dist/v0.11.14/node.lib                                                                                                                                                
gyp WARN install got an error, rolling back install                                                                                                                                                  
gyp ERR! configure error                                                                                                                                                                             
gyp ERR! stack Error: x64/node.lib local checksum 8b539aaaa72b00aa6b92b2dc9ee377159eaed4f01d0b7264a3c8ce06ac37971b not match remote 1c93d92da38a85a36b1e93556d16024d7ca6d342f9bfb9aafe066427a35c4928 
gyp ERR! stack     at deref (C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\lib\install.js:299:20)                                                                                         
gyp ERR! stack     at Request.<anonymous> (C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\lib\install.js:383:24)                                                                           
gyp ERR! stack     at Request.emit (events.js:129:20)                                                                                                                                                
gyp ERR! stack     at IncomingMessage.<anonymous> (C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\node_modules\request\request.js:1266:12)                                                 
gyp ERR! stack     at IncomingMessage.emit (events.js:129:20)                                                                                                                                        
gyp ERR! stack     at _stream_readable.js:907:16                                                                                                                                                     
gyp ERR! stack     at process._tickCallback (node.js:372:11)                                                                                                                                         
gyp ERR! System Windows_NT 6.3.9600                                                                                                                                                                  
gyp ERR! command "node" "C:\\Users\\johnh\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "configure"                                                                              
gyp ERR! cwd C:\git-projects\nodegit                                                                                                                                                                 
gyp ERR! node -v v0.11.14                                                                                                                                                                            
gyp ERR! node-gyp -v v1.0.2                                                                                                                                                                          
gyp ERR! not ok                                                                                                                                                                                      

C:\git-projects\nodegit (master)                                                                                                                                                                     
λ

Don't really know why it's doing this. When running this in v0.11.13 I get the following output:

C:\git-projects\nodegit (master)
λ node-gyp configure
gyp info it worked if it ends with ok
gyp info using node-gyp@1.0.2
gyp info using node@0.11.13 | win32 | x64
gyp info spawn python
gyp info spawn args [ 'C:\\Users\\johnh\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'msvs',
gyp info spawn args   '-G',
gyp info spawn args   'msvs_version=auto',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\git-projects\\nodegit\\build\\config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\johnh\\AppData\\Roaming\\npm\\node_modules\\node-gyp\\addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   'C:\\Users\\johnh\\.node-gyp\\0.11.13\\common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=C:\\Users\\johnh\\.node-gyp\\0.11.13',
gyp info spawn args   '-Dmodule_root_dir=C:\\git-projects\\nodegit',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'C:\\git-projects\\nodegit\\build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info ok

C:\git-projects\nodegit (master)
λ

Which is what I was expecting. Similar results also on node v0.10.*.

tbranyen commented Jan 17, 2015

Copy link
Copy Markdown
Member

Node 0.12 is vaporware at this point should we just ignore it?
On Jan 16, 2015 8:08 PM, "John Haley" notifications@github.com wrote:

It seems like a bug in node-gyp when running node-gyp configure it tries
to download a file (node.lib) and has a non-matching checksum.

I get this output from the console

C:\git-projects\nodegit (master)
λ node-gyp configure
gyp info it worked if it ends with ok
gyp info using node-gyp@1.0.2
gyp info using node@0.11.14 | win32 | x64
gyp http GET http://nodejs.org/dist/v0.11.14/node-v0.11.14.tar.gz
gyp http 200 http://nodejs.org/dist/v0.11.14/node-v0.11.14.tar.gz
gyp http GET http://nodejs.org/dist/v0.11.14/SHASUMS256.txt
gyp http GET http://nodejs.org/dist/v0.11.14/x64/node.lib
gyp http GET http://nodejs.org/dist/v0.11.14/node.lib
gyp http 200 http://nodejs.org/dist/v0.11.14/SHASUMS256.txt
gyp http 200 http://nodejs.org/dist/v0.11.14/x64/node.lib
gyp http 200 http://nodejs.org/dist/v0.11.14/node.lib
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: x64/node.lib local checksum 8b539aaaa72b00aa6b92b2dc9ee377159eaed4f01d0b7264a3c8ce06ac37971b not match remote 1c93d92da38a85a36b1e93556d16024d7ca6d342f9bfb9aafe066427a35c4928
gyp ERR! stack at deref (C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\lib\install.js:299:20)
gyp ERR! stack at Request. (C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\lib\install.js:383:24)
gyp ERR! stack at Request.emit (events.js:129:20)
gyp ERR! stack at IncomingMessage. (C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\node_modules\request\request.js:1266:12)
gyp ERR! stack at IncomingMessage.emit (events.js:129:20)
gyp ERR! stack at _stream_readable.js:907:16
gyp ERR! stack at process._tickCallback (node.js:372:11)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "node" "C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\bin\node-gyp.js" "configure"
gyp ERR! cwd C:\git-projects\nodegit
gyp ERR! node -v v0.11.14
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok

C:\git-projects\nodegit (master)
λ

Don't really know why it's doing this. When running this in v0.11.13 I get
the following output:

C:\git-projects\nodegit (master)
λ node-gyp configure
gyp info it worked if it ends with ok
gyp info using node-gyp@1.0.2
gyp info using node@0.11.13 | win32 | x64
gyp info spawn python
gyp info spawn args [ 'C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\gyp\gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'msvs',
gyp info spawn args '-G',
gyp info spawn args 'msvs_version=auto',
gyp info spawn args '-I',
gyp info spawn args 'C:\git-projects\nodegit\build\config.gypi',
gyp info spawn args '-I',
gyp info spawn args 'C:\Users\johnh\AppData\Roaming\npm\node_modules\node-gyp\addon.gypi',
gyp info spawn args '-I',
gyp info spawn args 'C:\Users\johnh.node-gyp\0.11.13\common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=C:\Users\johnh.node-gyp\0.11.13',
gyp info spawn args '-Dmodule_root_dir=C:\git-projects\nodegit',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'C:\git-projects\nodegit\build',
gyp info spawn args '-Goutput_dir=.' ]
gyp info ok

C:\git-projects\nodegit (master)
λ

Which is what I was expecting. Similar results also on node v0.10.*.

—
Reply to this email directly or view it on GitHub
#352 (comment).

johnhaley81 commented Jan 17, 2015

Copy link
Copy Markdown
Collaborator Author

yeah, we can ignore node 0.12

maxkorp commented Jan 19, 2015

Copy link
Copy Markdown
Collaborator

Well, are we dropping support for node 0.11? I mean it's meant to be unstable but that seems like a big change.

mcollina commented Jan 19, 2015

Copy link
Copy Markdown
Collaborator

If we support io.js then ok for not supporting 0.11.x. There should be at some point a 0.11.15 for general review which will be 0.12 (kind of). But at this point is all nonsense.

maxkorp commented Jan 19, 2015

Copy link
Copy Markdown
Collaborator

I agree. 0.12 is pretty much vaporware. IOjs dev sort of jumpstarted it back up a bit, but not really. Still missing deadlines by weeks/months now. if we can get it running consistantly with IO then i'm fine ditching 11, since IO is the new unstable, essentially.

johnhaley81 commented Jan 19, 2015

Copy link
Copy Markdown
Collaborator Author

Alright, I'm going to fix this guy up then and merge it in.

johnhaley81 commented Jan 19, 2015

Copy link
Copy Markdown
Collaborator Author

I'll also keep an eye on it and try to figure out the underlying issue on whatever spare time I have (lolololol).

If I can figure out wtf is happening and why it's dying then I'll put it back in. I wouldn't hold my breath on that though.

johnhaley81 added a commit that referenced this pull request Jan 19, 2015
Merge pull request #352 from nodegit/fix-appveyor
ccca4d3 
Fixed AppVeyor
johnhaley81 merged commit ccca4d3 into master Jan 19, 2015
johnhaley81 deleted the fix-appveyor branch January 19, 2015 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL