FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add 2 convenience methods to revwalk by maxkorp · Pull Request #384 · nodegit/nodegit · GitHub

Repository navigation

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension .js  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
58 changes: 58 additions & 0 deletions lib/revwalk.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var NodeGit = require("../");
var Revwalk = NodeGit.Revwalk;
var Promise = require("nodegit-promise");

var oldSorting = Revwalk.prototype.sorting;

Expand Down Expand Up @@ -55,4 +56,61 @@ Revwalk.prototype.walk = function(oid, callback) {
walk();
};


/**
* Walk the history grabbing commits until the checkFn called with the
* current commit returns false.
*
* @param {Function} checkFn
* @return {Array}
*/
Revwalk.prototype.getCommitsUntil = function(checkFn) {
var commits = [];
var walker = this;

function walkCommitsCb() {
return walker.next().then(function(oid) {
if (!oid) { return; }

return walker.repo.getCommit(oid).then(function(commit) {
commits.push(commit);
if (checkFn(commit)) {
return walkCommitsCb();
}
});
});
}

return walkCommitsCb().then(function() {
return commits;
});
};

/**
* Get some of commits.
*
* @param {Number} count (default: 10)
* @return {Array}
*/
Revwalk.prototype.getCommits = function(count) {
count = count || 10;
var promises = [];
var walker = this;

function walkCommitsCount(count) {
if (count === 0) { return; }

return walker.next().then(function(oid) {
if (!oid) { return; }

promises.push(walker.repo.getCommit(oid));
return walkCommitsCount(count - 1);
});
}

return walkCommitsCount(count).then(function() {
return Promise.all(promises);
});
};

module.exports = Revwalk;
35 changes: 35 additions & 0 deletions test/tests/revwalk.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,41 @@ describe("Revwalk", function() {
});
});

it("can get a specified number of commits", function() {
var test = this;
var storedCommits;
return test.walker.getCommits()
.then(function(commits) {
assert.equal(commits.length, 10);
storedCommits = commits;
test.walker = test.repository.createRevWalk();
test.walker.push(test.commit.id());

return test.walker.getCommits(8);
})
.then(function(commits) {
assert.equal(commits.length, 8);
for (var i = 0; i < 8; i++) {
assert.equal(commits[i].toString(), storedCommits[i].toString());
}
});
});

it("can get commits until you tell it not to", function() {
var test = this;
var magicSha = "b8a94aefb22d0534cc0e5acf533989c13d8725dc";

function checkCommit(commit) {
return commit.toString() != magicSha;
}

return test.walker.getCommitsUntil(checkCommit)
.then(function(commits) {
assert.equal(commits.length, 4);
assert.equal(commits[commits.length-1].toString(), magicSha);
});
});

// This test requires forcing garbage collection, so mocha needs to be run
// via node rather than npm, with a la `node --expose-gc [pathtohmoca]
// [testglob]`
Expand Down

Back | FazBrowse Home | New Git URL