FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix test issues by maxkorp · Pull Request #388 · nodegit/nodegit · GitHub

Repository navigation

Fix test issues - #388

Merged
maxkorp merged 5 commits into
masterfrom
fix-windows-tests
Feb 10, 2015
Merged

maxkorp merged 5 commits into
masterfrom
fix-windows-tests

Conversation

maxkorp commented Feb 4, 2015

Copy link
Copy Markdown
Collaborator

There were some slashes getting through to exec in the test runner which I suspect is behind #316.
This fixes those, and a few other things.

maxkorp changed the title Fix test issues WIP: Fix test issues Feb 4, 2015

Copy link
Copy Markdown
Collaborator

Nope :(

Any other ideas?

maxkorp force-pushed the fix-windows-tests branch 3 times, most recently from 6fa028a to 9eae810 Compare February 6, 2015 19:56

Copy link
Copy Markdown
Collaborator

Are we good to merge this in?

maxkorp commented Feb 10, 2015

Copy link
Copy Markdown
Collaborator Author

Not quite, tidying up some messes i made first, and I want to rebase etc beforehand. Gimme 30 to an hour 👍

Copy link
Copy Markdown
Collaborator

Great job on this btw. I hope this clears up our windows test issues :)

maxkorp commented Feb 10, 2015

Copy link
Copy Markdown
Collaborator Author

I'm hoping so. I was able to repro both issues in windows (clone not quite as consistantly, but fairly regularly) and they're both working locally now (and still work in osx), so I'm hopeful.

The big takeaway here is to listen to node-gyp's warnings about uninitialized vars, that's what was biting us with the status tests.

What weirds me out is that the status tests were passing for me locally before...

maxkorp commented Feb 10, 2015

Copy link
Copy Markdown
Collaborator Author

Huzzah!

maxkorp added a commit that referenced this pull request Feb 10, 2015
maxkorp merged commit 063615b into master Feb 10, 2015
johnhaley81 deleted the fix-windows-tests branch February 10, 2015 19:44
maxkorp changed the title WIP: Fix test issues Fix test issues Feb 10, 2015
tbranyen added this to the 0.3.0 milestone Mar 2, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL