Update to libgit2 v0.22.1 by johnhaley81 · Pull Request #390 · nodegit/nodegit · GitHub

This is the current status on updating nodegit to use the latest
libgit2. There are some major breaking API changes that need to be
accounted for and will force nodegit to also do a major update as
well.

Currently the missing callbacks are breaking the build and that's what I'm working on putting in.

When including `git2/sys/stream.h` we'll get a compile time error. Our fork of this fixes it for right now and we'll switch back over to libgit2 proper after the PR is merged back into the maint/0.22 branch

Currently playing whack-a-bug with building. Fix a bug/build/fix next bug/build/etc...

OMG IT BUILDS

That test passing on Travis is a false positive.

This reverts commit 902b837.

I added a skip on the HTTP test because although github does a redirect to HTTPS which might fail cert check on osx, libgit2 originally detects the HTTP and throws an error that a cert check is defined.

I added a skip for the "fetch all" test since it's timing out right now and I'm not sure why. I'm skipping it since it breaks all of the other tests after it.

So there's still some things that are funky right now.

With the "fetch all" test it's killing nodegit somehow. I think something's going on in C++ that's not getting cleaned up properly. I haven't been able to track it down.

Now with the http test we have libgit2 anrgy that we're setting a cert check on http since http doesn't use any certification. However, this particular http call redirects to https which then does use a cert which sometimes dies on osx.

I think I'll open up an issue on libgit2 about that since that seems like an oversight.

libgit2/libgit2#2904 for HTTP redirect to HTTPS cert check.

All of the examples are working. I think after we get Windows green lit we can merge this in!

Update to libgit2 v0.22.1

johnhaley81 mentioned this pull request Feb 7, 2015

Update to v0.22 of libgit2 #355

Closed

John Haley added 5 commits February 11, 2015 10:40

Sorted callbacks.json

1e65936

Point to libgit2 0.22.1

7d2f357

Starting to fix update errors

fcde576

Need to use our fork of libgit2 for the time being

841740b

When including `git2/sys/stream.h` we'll get a compile time error. Our fork of this fixes it for right now and we'll switch back over to libgit2 proper after the PR is merged back into the maint/0.22 branch

Fixed more build errors

969452a

johnhaley81 force-pushed the update-libgit2-0.22.0 branch from bb70c77 to 969452a Compare February 11, 2015 17:41

John Haley added 2 commits February 11, 2015 12:13

Value is ambigious now, must use namespace in declaration

85c94a3

Fixed bug with generate code for fixed length strings

0fd2f2f

John Haley added 13 commits February 12, 2015 08:30

Fixed git_cert_x509

02729b9

Fixed git_cred_username

dec34ba

Ignoring describe for right now

3304e4c

Fixed git_openssl

2fa3150

Payloads no longer need to be named payload

22804cb

Fixed returns for async functions when there is only 1 return

902b837

Fixed git_remote

054d646

Ignoring git_smart_subtransport_definition for now

334512c

Ignore git_stream for right now

ed5c6a8

OMG IT BUILDS

Fixed enum definitions

1314959

Fixed linking error with libgit2

8acbd9a

Ignoring git_describe_strategy_t for now

22416c4

git_thread_init is now git_libgit2_init

8377f42

John Haley added 5 commits February 12, 2015 13:25

Revert "Fixed returns for async functions when there is only 1 return"

3f0eaee

This reverts commit 902b837.

Ignoring git_remote_set_transport for right now

f2c7162

Added the rest of the unlinked libgit2 files

f68fa91

Fixed like 20 tests with 1 line change. Awwww yeah.

adcd8e0

Oid object now has allocfmt for backwards compatibility

f0119c2

John Haley added 5 commits February 13, 2015 10:29

Fixed git_tree_entry

8960812

git_remote_load is renamed to git_remote_lookup

2d461d0

Updated clone tests

25d7d88

I added a skip on the HTTP test because although github does a redirect to HTTPS which might fail cert check on osx, libgit2 originally detects the HTTP and throws an error that a cert check is defined.

Updated clone examples to use the new cert check API

b8c1203

Fixed remote tests

3096d0f

I added a skip for the "fetch all" test since it's timing out right now and I'm not sure why. I'm skipping it since it breaks all of the other tests after it.

Removed it.only from clone tests

3885887

tbranyen and others added 3 commits February 14, 2015 02:21

Implement new Remote.delete functionality

7c880b1

Fix remote fetch test

8784b08

Fixed remote tests

de6772e

Fixed build on windows

7e588e2

johnhaley81 changed the title [WIP] Update to libgit2 v0.22.1 Update to libgit2 v0.22.1 Feb 17, 2015

johnhaley81 added a commit that referenced this pull request Feb 17, 2015

Merge pull request #390 from nodegit/update-libgit2-0.22.0

8e6e447

Update to libgit2 v0.22.1

johnhaley81 merged commit 8e6e447 into master Feb 17, 2015

johnhaley81 deleted the update-libgit2-0.22.0 branch February 17, 2015 17:56

tbranyen added this to the 0.3.0 milestone Mar 2, 2015

Update to libgit2 v0.22.1 by johnhaley81 · Pull Request #390 · nodegit/nodegit · GitHub

Repository navigation

Update to libgit2 v0.22.1 - #390

Update to libgit2 v0.22.1#390
johnhaley81 merged 35 commits into
masterfrom
update-libgit2-0.22.0

johnhaley81 commented Feb 7, 2015

Uh oh!

johnhaley81 commented Feb 7, 2015

Uh oh!

johnhaley81 commented Feb 12, 2015

Uh oh!

johnhaley81 commented Feb 12, 2015

Uh oh!

johnhaley81 commented Feb 13, 2015

Uh oh!

johnhaley81 commented Feb 13, 2015

Uh oh!

johnhaley81 commented Feb 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Update to libgit2 v0.22.1 by johnhaley81 · Pull Request #390 · nodegit/nodegit · GitHub

Repository navigation

Update to libgit2 v0.22.1 - #390

Update to libgit2 v0.22.1#390johnhaley81 merged 35 commits intomasternodegit/nodegit:masterfrom update-libgit2-0.22.0nodegit/nodegit:update-libgit2-0.22.0Copy head branch name to clipboard

Conversation

johnhaley81 commented Feb 7, 2015

Uh oh!

johnhaley81 commented Feb 7, 2015

Uh oh!

johnhaley81 commented Feb 12, 2015

Uh oh!

johnhaley81 commented Feb 12, 2015

Uh oh!

johnhaley81 commented Feb 13, 2015

Uh oh!

johnhaley81 commented Feb 13, 2015

Uh oh!

johnhaley81 commented Feb 15, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Update to libgit2 v0.22.1#390
johnhaley81 merged 35 commits into
masterfrom
update-libgit2-0.22.0