Tree Entry getBlob() should also support the callback pattern. - #404
Closed
jeffwilcox wants to merge 3 commits into
Closed
jeffwilcox wants to merge 3 commits into
jeffwilcox wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Oh the irony, a 404 issue ID... |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good to me, what do you mean typo @johnhaley81 ? |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@jeffwilcox fyi that test will fail unless you're running an ssh agent and git's configured to use it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I found the typo... a missing space in a test name. Fixing! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Closing pull for now, will squash and create a new pr. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As this is my first contribution to this project, let me know what I can change, i.e. should I merge to a new branch name or is a direct-to-master preferred. (Contributing.MD didn't have a ton of info on the logistics of moving changes around)
Change Background
While moving code from the older v0.1.x codebase to the latest, I tried making minimal changes and renames in some functions. A majority of my Node code at this time is not using promises. While calling getBlob(callback) on a tree_entry, nothing happened.
I simply mimicked the format used for getTree in tree_entry to be consistent (although I'm not setting the entry instance on a property like the tree function does).
Tests
All mocha tests passing related to this change. However...